Closed Bug 232413 Opened 19 years ago Closed 19 years ago

Use of   to deal with TT CHOMP issues breaks scripts that parse Bugzilla output

Categories

(Bugzilla :: Bugzilla-General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: justdave, Assigned: gerv)

References

Details

Attachments

(1 file)

This broke bzbot.

[% bugs.size %] [% terms.bugs %] found.

should be:

[% bugs.size %] [%+ terms.bugs %] found.

Note the [%+, which disables PRE_CHOMP for that replacement.

We shouldn't be using   except for the places where we're using it to
prevent things from word-wrapping.
This is all over the code base.  I'll add a note about this to the DevGuide, I
encountered this in newadmin and had to ask bbaetz about it.
admin/products/groupcontrol/confirm-edit.html.tmpl:29:group '[% group.name
FILTER html %]' impacts [% group.count %] [% terms.bugs %] for
attachment/updated.html.tmpl:42:        of [% terms.bug %] [% bugid %]
submitted
bug/activity/show.html.tmpl:42:  <a href="show_bug.cgi?id=[% bug_id %]">Back to
[% terms.bug %]&nbsp;[% bug_id %]</a>
bug/dependency-tree.html.tmpl:41:  that <a href="show_bug.cgi?id=[% bugid %]">[%
terms.bug %]&nbsp;[% bugid %]</a> 
bug/dependency-tree.html.tmpl:63:  that <a href="show_bug.cgi?id=[% bugid %]">[%
terms.bug %]&nbsp;[% bugid %]</a> 
bug/edit.html.tmpl:229:          of [% terms.bug %]&nbsp;[% "${bug.dup_id}"
FILTER bug_link(bug.dup_id) %]
bug/edit.html.tmpl:549:  <th align="right">[% terms.Bug %]&nbsp;[% bug.bug_id %]
[%+ dep.title %]:</th>
bug/process/confirm-duplicate.html.tmpl:40:  on [% terms.bug %]&nbsp;[%
original_bug_id %] (the original) are currently set
bug/process/confirm-duplicate.html.tmpl:45:  <b>Adding the reporter to the CC
list of [% terms.bug %]&nbsp;[% original_bug_id %]
bug/process/confirm-duplicate.html.tmpl:61:    Yes, add the reporter to CC list
on [% terms.bug %]&nbsp;[% original_bug_id %]
bug/process/confirm-duplicate.html.tmpl:65:    No, do not add the reporter to CC
list on [% terms.bug %]&nbsp;[% original_bug_id %]
bug/process/confirm-duplicate.html.tmpl:69:    and revisit [% terms.bug
%]&nbsp;[% duplicate_bug_id %]</a>
bug/process/midair.html.tmpl:78:      and revisit [% terms.bug %]&nbsp;[% bug_id
%]</a>
bug/show-multiple.html.tmpl:52:      <font size="+3">[% terms.Bug %]&nbsp;[%
bug.bug_id %] - [% bug.short_desc FILTER html %]</font>
global/user-error.html.tmpl:209:    [%+ terms.bug %]&nbsp;[% bug_id FILTER html %],
list/list.html.tmpl:75:  [% bugs.size %]&nbsp;[% terms.bugs %] found.
list/list.html.tmpl:102:  [% bugs.size %]&nbsp;[% terms.bugs %] found.
Attached patch Patch v.1Splinter Review
This fixes all the ones I think should be fixed...

Gerv
Attachment #140198 - Flags: review?(justdave)
Comment on attachment 140198 [details] [diff] [review]
Patch v.1

This is the right thing to do.
Attachment #140198 - Flags: review?(justdave) → review+
Flags: approval?
Flags: approval? → approval+
Fixed.

Checking in template/en/default/admin/products/groupcontrol/confirm-edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/products/groupcontrol/confirm-edit.html.tmpl,v
 <--  confirm-edit.html.tmpl
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/attachment/updated.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/updated.html.tmpl,v
 <--  updated.html.tmpl
new revision: 1.11; previous revision: 1.10
done
Checking in template/en/default/bug/activity/show.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/activity/show.html.tmpl,v
 <--  show.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/bug/dependency-tree.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/dependency-tree.html.tmpl,v
 <--  dependency-tree.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
 edit.html.tmpl
new revision: 1.38; previous revision: 1.37
done
Checking in template/en/default/bug/show-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show-multiple.html.tmpl,v
 <--  show-multiple.html.tmpl
new revision: 1.15; previous revision: 1.14
done
Checking in template/en/default/bug/process/confirm-duplicate.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/confirm-duplicate.html.tmpl,v
 <--  confirm-duplicate.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/bug/process/midair.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/midair.html.tmpl,v
 <--  midair.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v
 <--  user-error.html.tmpl
new revision: 1.47; previous revision: 1.46
done
Checking in template/en/default/list/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list.html.tmpl,v 
<--  list.html.tmpl
new revision: 1.19; previous revision: 1.18
done

Gerv
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.