importMsgs.properties cleanup (remove unused strings + fix capitalization)

VERIFIED FIXED in mozilla1.8alpha2

Status

MailNews Core
Import
--
trivial
VERIFIED FIXED
14 years ago
9 years ago

People

(Reporter: Andreas Kunz, Assigned: Andreas Kunz)

Tracking

(Blocks: 1 bug)

Trunk
mozilla1.8alpha2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

2.67 KB, patch
neil@parkwaycc.co.uk
: review+
Bienvenu
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

14 years ago
User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113

Mailnews has "Save Message As", but then again: "Select address book file" as
file picker title. This should be all uppercase for consistency (at least the
nouns, but there are no verbs or whatever in that file, anyway).
(Browser had a similar bug recently about im-/exporting bookmarks)

While doing those changes, I also discovered several unused strings defined in
that file; those are all very old and probably should be removed.
Patch coming.


Reproducible: Always
Steps to Reproduce:
(Assignee)

Comment 1

14 years ago
Created attachment 140126 [details] [diff] [review]
patch

This changes four filepicker titles to uppercase and removes 11 unused strings.


Unused means they do not show up in the global tree
http://lxr.mozilla.org/mozilla/ (this also covers thunderbird), so it should be
safe. Most of them are more than 4 years old, many origin from the initial
checkin or other early checkins with no bug number and all traces of their
usage are lost. Or they actually were never used.
HomeButtonDesc and WorkButtonDesc e.g. have been checked in with bug 83585, but
none of the attached patches shows even a single usage of them.
Most of those unused strings seem to have been abandoned in favor of a title
named "Import" - without any specifics (e.g. I just tested this with
MailProgressTitle=Importing Mail).
Assignee: cavin → durbacher
Status: NEW → ASSIGNED
(Assignee)

Comment 2

14 years ago
Comment on attachment 140126 [details] [diff] [review]
patch

Requesting r= from mscott.
Please tell it if there is anything I might have missed when determining if
strings are unused.
Attachment #140126 - Flags: review?(mscott)
(Assignee)

Comment 3

14 years ago
Comment on attachment 140126 [details] [diff] [review]
patch

Transferring r= request to bienvenu.
Attachment #140126 - Flags: review?(mscott) → review?(bienvenu)
(Assignee)

Comment 4

14 years ago
Stephen, I guess you might review this as well if you want... ;-)
Andreas, why would I be qualified to review this?

AFAIK, I'm only 'qualified' to 'review' only the smallest of typos for Mail/News
-- and I'm not sure about that anymore, actually.

See bug 139859 for some older front-end work that I started but quickly
abandoned in this area.
(Assignee)

Comment 6

14 years ago
Comment on attachment 140126 [details] [diff] [review]
patch

Ok, then I'm sorry. I thought you had done lots of mailnews work and also done
reviews, but obviously I was wrong.

Oh, I see Neil is also mailnews peer! :-)
Attachment #140126 - Flags: review?(bienvenu) → review?(neil.parkwaycc.co.uk)

Updated

14 years ago
Attachment #140126 - Flags: review?(neil.parkwaycc.co.uk) → review+
(Assignee)

Comment 7

14 years ago
Comment on attachment 140126 [details] [diff] [review]
patch

Requesting sr= from bienvenu.
Attachment #140126 - Flags: superreview?(bienvenu)

Updated

14 years ago
Attachment #140126 - Flags: superreview?(bienvenu) → superreview+
Checking in mailnews/import/resources/locale/en-us/importMsgs.properties;
/cvsroot/mozilla/mailnews/import/resources/locale/en-us/importMsgs.properties,v
 <--  importMsgs.properties
new revision: 1.15; previous revision: 1.14
done
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
(Assignee)

Updated

14 years ago
Target Milestone: --- → mozilla1.8alpha2
Verified FIXED using LXR.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Blocks: 425749
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.