232488 - importMsgs.properties cleanup (remove unused strings + fix capitalization)

Status: VERIFIED FIXED

(MailNews Core :: Import, defect)

Description

[Andreas Kunz]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113

Mailnews has "Save Message As", but then again: "Select address book file" as
file picker title. This should be all uppercase for consistency (at least the
nouns, but there are no verbs or whatever in that file, anyway).
(Browser had a similar bug recently about im-/exporting bookmarks)

While doing those changes, I also discovered several unused strings defined in
that file; those are all very old and probably should be removed.
Patch coming.


Reproducible: Always
Steps to Reproduce:

Comment 1

[Andreas Kunz]

Attachment: patch

This changes four filepicker titles to uppercase and removes 11 unused strings.


Unused means they do not show up in the global tree
http://lxr.mozilla.org/mozilla/ (this also covers thunderbird), so it should be
safe. Most of them are more than 4 years old, many origin from the initial
checkin or other early checkins with no bug number and all traces of their
usage are lost. Or they actually were never used.
HomeButtonDesc and WorkButtonDesc e.g. have been checked in with bug 83585, but
none of the attached patches shows even a single usage of them.
Most of those unused strings seem to have been abandoned in favor of a title
named "Import" - without any specifics (e.g. I just tested this with
MailProgressTitle=Importing Mail).

Comment 2

[Andreas Kunz]

Comment on attachment 140126 [details] [diff] [review]
patch

Requesting r= from mscott.
Please tell it if there is anything I might have missed when determining if
strings are unused.

Comment 3

[Andreas Kunz]

Comment on attachment 140126 [details] [diff] [review]
patch

Transferring r= request to bienvenu.

Comment 4

[Andreas Kunz]

Stephen, I guess you might review this as well if you want... ;-)

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Andreas, why would I be qualified to review this?

AFAIK, I'm only 'qualified' to 'review' only the smallest of typos for Mail/News
-- and I'm not sure about that anymore, actually.

See bug 139859 for some older front-end work that I started but quickly
abandoned in this area.

Comment 6

[Andreas Kunz]

Comment on attachment 140126 [details] [diff] [review]
patch

Ok, then I'm sorry. I thought you had done lots of mailnews work and also done
reviews, but obviously I was wrong.

Oh, I see Neil is also mailnews peer! :-)

Comment 7

[Andreas Kunz]

Comment on attachment 140126 [details] [diff] [review]
patch

Requesting sr= from bienvenu.

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in mailnews/import/resources/locale/en-us/importMsgs.properties;
/cvsroot/mozilla/mailnews/import/resources/locale/en-us/importMsgs.properties,v
 <--  importMsgs.properties
new revision: 1.15; previous revision: 1.14
done

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using LXR.