Closed Bug 232607 Opened 21 years ago Closed 21 years ago

add ui for smooth scroll preference

Categories

(SeaMonkey :: UI Design, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.7alpha

People

(Reporter: Biesinger, Assigned: Biesinger)

Details

Attachments

(1 file, 1 obsolete file)

to allow users to find this preference easier, the preference dialog should have
an option for it.
Severity: normal → enhancement
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.7alpha
Attached patch patch (obsolete) — Splinter Review
Attachment #140208 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 140208 [details] [diff] [review]
patch

>+pref("general.smoothScroll", false);
I don't think this is the best place for this pref, e.g. in case someone needs
to change the default for some obscure OS.

>+    <checkbox id="enableSmoothScroll"
>+              label="&enableSmoothScroll.label;"
>+              accesskey="&enableSmoothScroll.accesskey;"
>+              prefstring="general.smoothScroll"/>
I'm not convinced exactly where the best place for this checkbox is.

>+<!ENTITY enableSmoothScroll.label "Enable smooth scrolling">
"Use", rather than "Enable", please (also above).
Attachment #140208 - Flags: review?(neil.parkwaycc.co.uk) → review-
Attached patch patch v2Splinter Review
per irc discussion, make the checkbox the third one in that dialog
Attachment #140208 - Attachment is obsolete: true
Attachment #140264 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 140264 [details] [diff] [review]
patch v2

>+      "useSiteIcons", "enableAutomaticImageResizing", "useSmoothScroll"
Hmm... do we normally keep these in order?
Attachment #140264 - Flags: review?(neil.parkwaycc.co.uk) → review+
Comment on attachment 140264 [details] [diff] [review]
patch v2

no idea if we do, but ok, I'll swap useSmoothScroll and
enableAutomaticImageResizing in the array
Attachment #140264 - Flags: superreview?(roc)
Attachment #140264 - Flags: superreview?(roc) → superreview+
checked in
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Core → Mozilla Application Suite
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: