232852 - Use repeatOverlay files to centralize repeat functionality of dialogs

Status: RESOLVED WORKSFORME

(Calendar :: General, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

User-Agent:       
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040201

the files content/repeatOverlay.* 
are missing in the jar.mn definition. Are they needed?
If yes please commit the attached patch. (If not, the files could be removed?)

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

Attachment: patch to add probably missing files

Comment 2

[Mostafa Hosseini]

Those files are there as the first step to centralize the "repeat" dialog UI.
They carry the "repeat" functionality that is currently being duplicated in
eventDialogs and todoDialogs. The goal is to eventually use them as overlays in
eventDialogs and todoDialogs and remove the redundant code from those dialogs.
So we can't add them to jar.mn because they aren't currently being used and we
don't want to remove them because we eventually have to use them. But I'll
change the summary so this doesn't fall through the cracks.

Comment 3

[Joey Minta]

Files named repeatOverlay.* no longer exist
(http://lxr.mozilla.org/mozilla/search?string=repeatOverlay).

Comment 4

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: General. Be afraid for your sanity!