232903 - "edit" hook for global/useful-links.html.tmpl

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

We need a hook for the example in the documentation.

template: global/useful-links.html.tmpl
where: 
    [% ', <a href="editkeywords.cgi">keywords</a>' 
                                              IF user.groups.editkeywords %]
    [% Hook.process("edit") %]

purpose: let extensions add more links to the "edit: foo, bar, baz" section of
the footer.

extension: will be used by testrunner, among others
http://www.willowriver.net/products/testrunner.php

Dave, does this look good to you?

Comment 1

[Myk Melez [:myk] [@mykmelez]]

*** Bug 232908 has been marked as a duplicate of this bug. ***

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Patch from bug 232908 ;-)

Gerv

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 140452 [details] [diff] [review]
Patch v.1

Yup, looks good.

Comment 4

[Gervase Markham [:gerv]]

myk: can you approve?

Gerv

Comment 5

[Myk Melez [:myk] [@mykmelez]]

a=myk

Comment 6

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/global/useful-links.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/useful-links.html.tmpl,v
 <--  useful-links.html.tmpl
new revision: 1.22; previous revision: 1.21
done

Gerv

Comment 7

[Dave Miller [:justdave]]

not ok 65 - (en/default) template/en/default/global/useful-links.html.tmpl has
unfiltered directives:
#   73: Hook.process("edit") 
# --ERROR
#     Failed test (t/008filter.t at line 117)

Failed Test   Stat Wstat Total Fail  Failed  List of Failed
-------------------------------------------------------------------------------
t/008filter.t    1   256   137    1   0.73%  65
/usr/opt/perl-5.8.0/bin/perl runtests.pl --verbose complete
/usr/opt/perl-5.8.0/bin/perl runtests.pl --verbose found FATAL compile errors

Comment 8

[Dave Miller [:justdave]]

Tinderbox is burning, if you didn't catch that. :)

Comment 9

[Christian Reis]

I'm not sure what the correct fix for this is, but I couldn't fix it by adding
to filterexceptions, and cooked up this which fixes the redness locally:

diff -u -p -r1.7 008filter.t
--- t/008filter.t       6 Sep 2003 19:23:43 -0000       1.7
+++ t/008filter.t       3 Feb 2004 11:17:28 -0000
@@ -182,6 +182,9 @@ sub directive_ok {
     
     # Params
     return 1 if $directive =~ /^Param\(/;
+    
+    # Hooks
+    return 1 if $directive =~ /^Hook.process\(/;
 
     # Other functions guaranteed to return OK output
     return 1 if $directive =~ /^(time2str|GetBugLink|url)\(/;

Is this what should be done?

Comment 10

[Gervase Markham [:gerv]]

Kiko: that's the correct fix. Hook.process directives should be exempt from
filter checks.

Gerv

Comment 11

[Christian Reis]

Checked in assuming that's a stamp, on the rationale that the forest is burning
-- back me out and punish me later if I did wrong.

Comment 12

[Dave Miller [:justdave]]

Looks good to me.  Thanks, kiko!

Comment 13

[Gervase Markham [:gerv]]

Yes - thanks :-)

Gerv

Comment 14

[Dave Miller [:justdave]]

No...  I think the edit section is getting too cluttered already.  I've been
hoping to make it all go away in favor of specific links to preferences and
system admin, which would then in turn have the links to the specific places.

Comment 15

[Gervase Markham [:gerv]]

Dave: was that comment meant for bug 232338?

Gerv

Comment 16

[Dave Miller [:justdave]]

hmm, no, it was meant for this bug, but I had bugmail out of order, and it was
way out of context.  Feel free to ignore it. :)