232933 - javascript window.open('file or bookmark', '_self') does nothing..

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Martin Legris]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007 Firebird/0.7

When using javascript window.open function, you can specify for it to open 
pages within the same window, therefore not create pop-ups. I use it 
throughout my web sites that I develop to forward to new pages.

I also use it to redirect to bookmarks inside web pages. Firebird seems to 
block that function completely, or atleast it does NOTHING. 

Reproducible: Always
Steps to Reproduce:
1. <script language='javascript'>window.open('mypage.html', '_self');</script>

Actual Results:  
nothing.

Expected Results:  
it should open a new page in the same window.

Comment 1

[Jason Barnabe (np)]

Confirming.

Comment 2

[Jason Barnabe (np)]

Attachment: testcase

If you turn on pop-up blocking, window.open("whatever", "_self") that runs
automatically when a page is loaded is treated like a popup. If pop-up blocking
is off, it behaves normally. If the code is called from an onClick, it works
normally.

I'm thinking regression from bug 197919.

Comment 3

[Jesse Ruderman]

This was reported against Firebird 0.7, so how can it be a regression from bug
197919?

Comment 4

[Jason Barnabe (np)]

Because it's present now (Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.7a) Gecko/20040205 Firebird/0.8.0+)

Comment 5

[Jason Barnabe (np)]

Oh wait, I get what you're saying now. Heh.

Comment 6

[Dan M]

Attachment: popup blocker once again tolerates window.open targeted to _self, _top et.al.

Can't blame 197919. This hasn't worked since I broke it in rev 1.605 last June.
C'mon folks! What sort of standard are you holding me to, eh? June, I say!

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 140810 [details] [diff] [review]
popup blocker once again tolerates window.open targeted to _self, _top et.al.

Doh!  sr=bzbarsky

Comment 8

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 140810 [details] [diff] [review]
popup blocker once again tolerates window.open targeted to _self, _top et.al.

r=caillon.

For reference, bug 177526 contains the original issue.

Aside: you might also wish to change the first portion of this function (not
shown in patch) to:

  PRBool allowWindow = !IsPopupBlocked(mDocument);

which would save you an assignment in the case where popup blocking is enabled
(if you make the relevant updates).

Comment 9

[Dan M]

I didn't understand the last part of comment 8, how to make the initial
assignment to allowWindow more efficient. I suspect Christopher is looking at an
older version of the file. Or maybe I'm just dense today. And he took more than,
like, 15 seconds to get back to me with details. Perhaps an opportunity missed,
but no harm done. The patch is in as posted.

Comment 10

[Boris Zbarsky [:bzbarsky]]

*** Bug 235818 has been marked as a duplicate of this bug. ***