233036 - In <abCardOverlay.js>, "Warning: reference to undefined property window.arguments[0].QueryInterface"

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6) Gecko/20040113] (W98SE)

{
Warning: reference to undefined property window.arguments[0].QueryInterface
Source File: chrome://messenger/content/addressbook/abCardOverlay.js
Line: 53
}

Reproducible: 100%
1. Window > Address Book > New Card

Comment 1

[Serge Gautherie (:sgautherie)]

neil:
asking for your insight:

Code is
{{
  var cardproperty;

  // if one is passed in, use it
  try {
      cardproperty =
window.arguments[0].QueryInterface(Components.interfaces.nsIAbCard);     <-- 53 !
  }
  catch (ex) {
    cardproperty =
Components.classes["@mozilla.org/addressbook/cardproperty;1"].createInstance(Components.interfaces.nsIAbCard);
  }
}}

|window.arguments[0]| is (not null) '[object Object]'.

I don't know how to fix this code.

Comment 2

[Karsten Düsterloh]

If you can make/be sure that window.arguments[0] exist, you could use

var cardproperty = window.arguments[0];
if (!(cardproperty instanceof Components.interfaces.nsIAbCard))
{
    cardproperty = Components.classes["@mozilla.org/addressbook/cardproperty;1"]
                             .createInstance(Components.interfaces.nsIAbCard);
}

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) "mailnews/" <abCardOverlay.js>

Bug fix, plus some reformatting/var. removal/etc.

Comment 4

[[e-mail]]

Comment on attachment 140600 [details] [diff] [review]
(Av1) "mailnews/" <abCardOverlay.js>

>+    (("arguments" in window) && window.arguments[0] &&
window.arguments[0] might be a strict JS warning...

>+  var focus = (gEditCard.displayLastNameFirst)
>+              ? document.getElementById('LastName')
>+              : document.getElementById('FirstName');
I think I'd prefer if you used ? 'LastName' : 'FirstName' instead.

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Av1a) "mailnews/" <abCardOverlay.js>

Av1, with comment 4 suggestion(s).

Comment 6

[[e-mail]]

Comment on attachment 140767 [details] [diff] [review]
(Av1a) "mailnews/" <abCardOverlay.js>

>+  var focus = document.getElementById(gEditCard.displayLastNameFirst
>+                                      ? 'LastName'
>+                                      : 'FirstName');
Might as well put these two on the same line.

>@@ -513,10 +499,8 @@ function CleanUpWebPage(webPage)
>   if ( webPage.length && webPage.search("://") == -1 )
>   {
>     // check for missing / on http://
>-    if ( webPage.substr(0, 6) == "http:/" )
>-      return( "http://" + webPage.substr(6) );
>-    else
>-      return( "http://" + webPage );
>+    return( "http://" + ((webPage.substr(0, 6) == "http:/")
>+                         ? webPage.substr(6) : webPage));
Whoops, I didn't spot this bit before. Unless you want to fix this to use the
uri fixup component, please leave this alone.

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) "mailnews/" <abCardOverlay.js> [Wrong attachment :-(]

Av1a, with comment 6 suggestion(s).

Comment 8

[Serge Gautherie (:sgautherie)]

Attachment: (Av2a) "mailnews/" <abCardOverlay.js>

Av1a, with comment 6 suggestion(s).

Comment 9

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7b) Gecko/20040421] (<-- 1.7rc1 !)
(W98SE)

mscott:
Did you miss this sr=? ?

Comment 10

[Serge Gautherie (:sgautherie)]

Attachment: (Av2b-MAS) <abCardOverlay.js> [Check in: Comment 14]

Av2a, updated to current trunk.

Scott:
Could you super-review this more than 7 months old patch ?

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 169004 [details] [diff] [review]
(Av2b-MAS) <abCardOverlay.js>
[Check in: Comment 14]

No super-review from <[e-mail]> since "2004-02-06" :-(

Comment 12

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a6) Gecko/20050111] (release) (W98SE)

Bug still there.

Comment 13

[[e-mail]]

I think I fixed the bitrot ok, but leaving the bug open just in case...

Comment 14

[Serge Gautherie (:sgautherie)]

Comment on attachment 169004 [details] [diff] [review]
(Av2b-MAS) <abCardOverlay.js>
[Check in: Comment 14]

(In reply to comment #13)
> I think I fixed the bitrot ok, but leaving the bug open just in case...

Changes in the checked in version:
{ 2005-01-18 15:28	neil%parkwaycc.co.uk	mozilla/ mailnews/ addrbook/
resources/ content/ abCardOverlay.js	   1.52 }

OnLoadNewCard(): |-125,11 +110,11| replaced by |+123,7 +108,7|
SetCardDialogTitle(): |top.window.title| had bitrotted to |document.title|.

Comment 15

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-MAS) <abCardOverlay.js> [Checked in: Comment 16]

Fixes a (indentation) nit from Av2b.

Neil,
Can you check it in on my behalf ? Thanks. (assuming implicit same r+/sr+)

Comment 16

[Serge Gautherie (:sgautherie)]

Comment on attachment 171699 [details] [diff] [review]
(Bv1-MAS) <abCardOverlay.js>
[Checked in: Comment 16]


Check in: { 2005-01-19 01:42	neil%parkwaycc.co.uk	mozilla/ mailnews/
addrbook/ resources/ content/ abCardOverlay.js	     1.53 }

Comment 17

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1-TB) <abCardOverlay.js> [Checked in: Comment 24]

Av2b and Bv1, ported to TB.

I don't use TB: Could you test/review/check in this patch ? Thanks.

Comment 18

[Serge Gautherie (:sgautherie)]

Attachment: (Dv1-MAS) <abCardOverlay.js> [Checked in: Comment 23]

Fixes a few more nits found while preparing Cv1-TB port.

Better to keep the 2 file contents identical.

Neil,
Can you check it in on my behalf ? Thanks. (assuming implicit same r+/sr+)

Comment 19

[Mark Banner (:standard8)]

Serge, these patches seem to work on TB & MAS without causing problems (I've
just tested them with todays trunk) you possibly just need to give neil & david
a nudge to get them reviewed.

Comment 20

[Serge Gautherie (:sgautherie)]

Comment on attachment 171817 [details] [diff] [review]
(Cv1-TB) <abCardOverlay.js>
[Checked in: Comment 24]

David (or Scott):

This has been working in MAS trunk for 4 months, and Mark has now tested it in
TB too.

Comment 21

[Serge Gautherie (:sgautherie)]

Comment on attachment 171819 [details] [diff] [review]
(Dv1-MAS) <abCardOverlay.js>
[Checked in: Comment 23]

'approval1.8b3=?': (SeaMonkey only)
Trivial U.I. code cleanup, no risk.

Comment 22

[Serge Gautherie (:sgautherie)]

Comment on attachment 171817 [details] [diff] [review]
(Cv1-TB) <abCardOverlay.js>
[Checked in: Comment 24]

'approval1.8b3=?':
(Trivial) U.I. code cleanup, no risk.
(Has already been in SeaMonkey for months, mostly)

Comment 23

[Serge Gautherie (:sgautherie)]

Comment on attachment 171819 [details] [diff] [review]
(Dv1-MAS) <abCardOverlay.js>
[Checked in: Comment 23]


Check in: { 2005-07-08 17:23	neil%parkwaycc.co.uk	mozilla/ mailnews/
addrbook/ resources/ content/ abCardOverlay.js	     1.55 }

Comment 24

[Mark Banner (:standard8)]

Comment on attachment 171817 [details] [diff] [review]
(Cv1-TB) <abCardOverlay.js>
[Checked in: Comment 24]

I just checked this in:
/cvsroot/mozilla/mail/components/addrbook/content/abCardOverlay.js,v  <-- 
abCardOverlay.js
new revision: 1.8; previous revision: 1.7