cancelling a download crashes

RESOLVED FIXED in mozilla1.7alpha

Status

SeaMonkey
Download & File Handling
--
critical
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

({crash, regression})

Trunk
mozilla1.7alpha
x86
Windows 2000
crash, regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

nsDownloadManager::CancelDownload calls DownloadEnded, which removes the
downlaod from the hashtable and releases the reference... CancelDownload still
has a weak reference, uses it to access the download object, and crashes.
Created attachment 140633 [details] [diff] [review]
patch

additional changes: Do not use .Get in this file, only use GetWeak - saves some
codesize
Attachment #140633 - Flags: review?(neil.parkwaycc.co.uk)
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.7alpha
Severity: normal → critical

Comment 2

14 years ago
Comment on attachment 140633 [details] [diff] [review]
patch

Nice cleanup too.
Attachment #140633 - Flags: review?(neil.parkwaycc.co.uk) → review+
Attachment #140633 - Flags: superreview?(bzbarsky)
Comment on attachment 140633 [details] [diff] [review]
patch

Sure.  sr=bzbarsky
Attachment #140633 - Flags: superreview?(bzbarsky) → superreview+
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.