23320 - JS_[Push|Convert]Arguments do not correctly tag address of va_list

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Chris Waterson]

On some platforms (e.g., Linux/PPC), the va_list is defined as an array, in
which case, it is not correct to take the addressof the ``ap'' object.

Tip o' the hat to Franz Sirl for that; see
news://news.mozilla.org/4.2.2.19991206110734.04a3e4c0%40mail.lauterbach.com

Attaching a patch for jsapi.cpp that does this...

Comment 1

[Chris Waterson]

Attachment: proposed fix

Comment 2

[Chris Waterson]

FWIW, this bug was submitted using Mozilla 5.0, Linux/PPC!

Comment 3

[Brendan Eich [:brendan]]

Thanks!  Who defines HAVE_VA_LIST_AS_ARRAY, anyhoo?

Waterson, would you be willing to check in, ra=[e-mail]?  My js tree
is holding big changes, including to jsapi.c.  I'm happy to roll this one in,
but I won't be checking in till early next week.

/be

Comment 4

[Chris Waterson]

n.p., I'll check it in. The HAVE_VA_LIST_ARRAY is defined as part of our
autoconfig joy. Will this cause you any grief in modular JS-land?

Comment 5

[Chris Waterson]

fix checked in. mozilla lives on Linux/PPC!