JS_[Push|Convert]Arguments do not correctly tag address of va_list

RESOLVED FIXED in M13

Status

()

defect
P3
major
RESOLVED FIXED
20 years ago
18 years ago

People

(Reporter: waterson, Assigned: waterson)

Tracking

Trunk
Other
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

On some platforms (e.g., Linux/PPC), the va_list is defined as an array, in
which case, it is not correct to take the addressof the ``ap'' object.

Tip o' the hat to Franz Sirl for that; see
news://news.mozilla.org/4.2.2.19991206110734.04a3e4c0%40mail.lauterbach.com

Attaching a patch for jsapi.cpp that does this...
Posted patch proposed fixSplinter Review
FWIW, this bug was submitted using Mozilla 5.0, Linux/PPC!
Status: NEW → ASSIGNED
Target Milestone: M13
Thanks!  Who defines HAVE_VA_LIST_AS_ARRAY, anyhoo?

Waterson, would you be willing to check in, ra=brendan@mozilla.org?  My js tree
is holding big changes, including to jsapi.c.  I'm happy to roll this one in,
but I won't be checking in till early next week.

/be
Assignee: brendan → waterson
Status: ASSIGNED → NEW
n.p., I'll check it in. The HAVE_VA_LIST_ARRAY is defined as part of our
autoconfig joy. Will this cause you any grief in modular JS-land?
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
fix checked in. mozilla lives on Linux/PPC!
You need to log in before you can comment on or make changes to this bug.