233268 - Popup Blocker catches javascript in personal toolbar

Status: RESOLVED EXPIRED

(SeaMonkey :: General, defect)

Description

[km]

User-Agent:       
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.7a) Gecko/20040205

I have an item in my personal toolbar that runs a javascript which opens a
window. In recent builds this has started being blocked by the popup blocker
when I click on the the item on the toolbar.

This will happen for example with the item

javascript:void(win=window.open('http://www.mozilla.org', 'Mozilla',
'width=550,height=350,resizable=yes,scrollbars=yes,menubar=no,status=no'))

It doesn't help to put the destination (mozilla.org in this case) in the
popup whitelist. It doesn't help to put the location of currently displayed page
either. I wouldn't expect either of these locations be relevant. If the source
of the javascript is personal toolbar, it should not be blocked.







Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Dan, that sounds like yours....

Reporter, the personal toolbar is never the source of JS.  Any JS in it runs in
the page context, so the page is treated as the source of JS.

Comment 2

[Dan M]

Works for me on a recent Windows build. Just as for a normal hyperlink, there's
no DOM event on record when the window.open comes through, so the popup blocker
is uninterested.

Alright then. km, working under the assumption that it's the new popup blocking
code from bug 197919 that's to blame, would you try a couple of things?

(1) Does the same thing happen to standard website page links? Just find any
website that contains a normal, untricky link that opens a new window, <a
href="javascript:window.open()">. Is that blocked? The "Make CNN.com Your Home
Page" link right at the top of http://www.cnn.com/ is an example. Not to worry,
it just opens a new window. Doesn't do anything to Mozilla.

(2) Add mousedown, then mouseup, to your dom.popup_allowed_events preference.
(click should already be allowed.) There's no UI; you'll have to use
about:config or take a text editor to the prefs file. I have a feeling you
already know how to do all these things. Do either of those help? Which one,
specifically?

Comment 3

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 4

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.