Change XP_PC to XP_WIN | XP_OS2 in jssh.c

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: Amos Blackman, Assigned: timeless)

Tracking

Trunk
x86
Windows NT
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

15 years ago
User-Agent:       
Build Identifier: js-1.5-rc6

I believe this should be changed to XP_WIN, or eliminated entirely:

mozilla/js/src/sh/jssh.c:
     56 /* Platform-dependent stuff */
     57 #ifdef XP_PC
     58 #   define ENVIRON _environ
     59 #   define PUTENV  _putenv
     60 #   define POPEN   _popen
     61 #   define PCLOSE  _pclose
     62 #   define PLATFORM "PC"

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
(Assignee)

Updated

15 years ago
Assignee: general → timeless
(Assignee)

Updated

15 years ago
Status: UNCONFIRMED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Summary: XP_PC still referenced in jssh.c → Change XP_PC to XP_WIN | XP_OS2 in jssh.c

Comment 1

15 years ago
No reference as to what bug/patch might have fixed this.
->WORKSFORME
Status: RESOLVED → UNCONFIRMED
Resolution: FIXED → ---

Updated

15 years ago
Status: UNCONFIRMED → RESOLVED
Last Resolved: 15 years ago15 years ago
Resolution: --- → WORKSFORME
(Assignee)

Comment 2

15 years ago
this is not part of the build, spidermonkey developers are allowed to make
changes to these files without any bug. i made the change.
Status: RESOLVED → UNCONFIRMED
Resolution: WORKSFORME → ---
(Assignee)

Updated

15 years ago
Status: UNCONFIRMED → RESOLVED
Last Resolved: 15 years ago15 years ago
Resolution: --- → FIXED

Comment 3

15 years ago
Fair enough but then say something like "Fixed by changes by Timeless" so that
this can be tracked properly in b.m.o.
You need to log in before you can comment on or make changes to this bug.