Closed
Bug 233443
Opened 21 years ago
Closed 21 years ago
Mozilla 1.6 crashes after clicking on the "mobile"-Link [@ GlobalWindowImpl::FireAbuseEvents]
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.7alpha
People
(Reporter: nico.oberbanscheidt, Assigned: danm.moz)
References
()
Details
(Keywords: crash, regression)
Crash Data
Attachments
(7 files, 1 obsolete file)
The sony-page
User-Agent:
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; de-AT; rv:1.6) Gecko/20040113
On the Page http://www.sony.de/PageView.do?site=odw_de_DE click on "Mobile".
There will pop up a window stating "You will be forwarded to
www.sonyericsson.....". After a few seconds Mozilla will simply crash.
This is on OS X 10.3.1 with Mozilla 1.6 and Powerbook G4 / 800.
Reproducible: Always
Steps to Reproduce:
See deatails. Simply click and wait.
Actual Results:
Crash of Mozilla.
Expected Results:
After clicking link forward-action should proceed normal.
|
Reporter | |
Comment 1•21 years ago
|
||
|
|
Reporter | |
Comment 2•21 years ago
|
||
I have managed to capture this appr. two to three seconds before crash.
|
|
Reporter | |
Comment 3•21 years ago
|
||
|
||
Comment 4•21 years ago
|
||
|
|
||
Comment 5•21 years ago
|
||
Confirming bug, 2004-02-02-07 trunk Linux.
Could be the same as bug 221492.
Assignee: general → general
Severity: normal → critical
Status: UNCONFIRMED → NEW
Component: Browser-General → DOM: Level 0
Ever confirmed: true
Keywords: crash
OS: MacOS X → All
QA Contact: general → ian
Hardware: Macintosh → All
Summary: Mozilla 1.6 crashes after clicking on the "mobile"-Link → Mozilla 1.6 crashes after clicking on the "mobile"-Link [@ GlobalWindowImpl::FireAbuseEvents]
|
|
||
Comment 6•21 years ago
|
||
Regression occured between 2003-09-16-05 and 2003-09-18-22.
Keywords: regression
Works for me on my Windows build.
Annotated steps to reproduce:
1) Go to the URL named, click the "Mobile" link
1a) site opens a new window, we'll call it window 2
and by the way, it's another incidence of the weird, astonishingly common,
circumlocutory construct
<a href="#" onclick="MM_openBrWindow('http://somewhere')">
of bug 197919 comment 32 fame.
1b) Window 2 attempts to open yet another new window (let's call it window 3)
from a timer, and closes itself on a different timer. It looks basically
like this
<html><head><script>
function closeWindow() {
window.close();
}
function openWindow() {
var _href = document.getElementById("myLink").href;
window.open(_href,"");
}
function delay() {
setTimeout("openWindow()",2000); // timer A
setTimeout("closeWindow()",2200); // timer B
}
</script></head>
<body onload="delay()">
you are being transferred to
<a id="myLink" href="http://www.mozilla.org/">somewhere else</a>
</body></html>
1c) The crash happens when the popup blocker (rightly) refuses to open window 3
and important parts of window 2 are missing as it tries to recover.
Apparently timer B is slipping in and breaking down window 2 as it's still
trying to open window 3 from timer A. It's easy enough to slap a null check into
FireAbuseEvents to stop this particular crash but I wonder what worse things
would happen if the window open hadn't been blocked.
Other code referencing the top window checks it for null. This is the "I trust
all the other edge case null checks this file has accumulated over the years
and dully follow suit" patch.
Assignee: general → danm-moz
Status: NEW → ASSIGNED
Attachment #140907 -
Flags: superreview?(jst)
Attachment #140907 -
Flags: review?(bzbarsky)
|
|
||
Comment 9•21 years ago
|
||
Comment on attachment 140907 [details] [diff] [review]
null check top window in FireAbuseEvents
Heh. r=bzbarsky
Attachment #140907 -
Flags: review?(bzbarsky) → review+
|
||
Comment 10•21 years ago
|
||
Comment on attachment 140907 [details] [diff] [review]
null check top window in FireAbuseEvents
sr=jst
Attachment #140907 -
Flags: superreview?(jst) → superreview+
|
|
Reporter | |
Comment 11•21 years ago
|
||
If you like and are interested......
|
|
Reporter | |
Comment 12•21 years ago
|
||
If you like and are interested.....
|
|
Assignee | |
Comment 13•21 years ago
|
||
Patch is checked in. Nico, please test using a 20040210 nightly build. (Or pull
and build your own, of course!) Let us know if it's fixed.
|
|
||
Comment 14•21 years ago
|
||
*** Bug 221492 has been marked as a duplicate of this bug. ***
|
|
Reporter | |
Comment 15•21 years ago
|
||
Two weeks ago all of a sudden the Mozilla-Menues will show in German, but the
Apple-Menue is in English. When Mozilla is quit, the Apple-Menue will return to
German as specified in the Preferences.
Unfortunately I do not know what action exactly caused this to happen. It just
happened all of a sudden. I do regularly cron-jobs and almost never shut down
the computer but put it to sleep.
Strange.........
|
|
Reporter | |
Comment 16•21 years ago
|
||
Comment on attachment 141873 [details]
Sudden Change: The Apple-Menue and Mozilla Menues
Sorry, this belongs to another bug.
Attachment #141873 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 17•21 years ago
|
||
I'm going to assume this was fixed by build 20040210, then. Reopen if mistaken.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.7alpha
|
||
Updated•14 years ago
|
Crash Signature: [@ GlobalWindowImpl::FireAbuseEvents]
You need to log in
before you can comment on or make changes to this bug.
Description
•