Closed Bug 233549 Opened 21 years ago Closed 16 years ago

Importing/loading bookmarks doesn't convert iso-2022-jp text to UTF-8

Categories

(SeaMonkey :: Bookmarks & History, defect)

SeaMonkey 1.0 Branch
x86
Windows 95
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: Yukinoroh, Unassigned)

Details

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.6) Gecko/20040113

Mozilla 1.6 crashes when selecting bookmarks with page down key in Manage
Bookmarks window

Reproducible: Always
Steps to Reproduce:
1. Bookmarks -> Manage Bookmarks
2. Hold Shift, then hold page down

Actual Results:  
Crash

Expected Results:  
No crash

"Unknown module"
Changing summary.

Browser crashes when when rendering New-JIS text in bookmark name. No matter 
what kind of key I use or even the mouse, it crashes over an item which as got 
the following name :

(1J) $B#T#T#W2sEz=q(B 

The text is not corrupted (I've checked by pasting it to NJStar Japanese WP). 
Character before $B and before (B are an escape sentence. My bookmark file was 
imported from a Japanese Netscape Communicator 4.5 bookmark file, in which the 
item name is in New-JIS text as well. Although that text is not displayed in 
Japanese either in NS4.5jp, viewing that bookmark item won't make the browser 
crash.

Since Mozilla's bookmark file format seems to be unicode-based (my OS is 
Shift-JIS based and I see garbage when viewing Mozilla bookmark file as text), 
my guess would be that Mozilla tries to interpret some characters in that string 
(maybe the escape character) as the begining of some 16+ byte unicode character 
and crashes.

I see two possible solutions : either converting New-JIS strings to unicode when 
importing from NS4.5 format, or ignoring the escape character (I wonder if 
that's possible...)
Summary: Crash when selecting bookmarks in Manage Bookmarks window → Crash in Manage Bookmarks window when rendering New-JIS text
Might be related to bug #233540
I can't reproduce the behaviour described at #8 in bug #233540; the problematic 
bookmark item alone (I've edited the file with Notepad) will make the Bookmarks 
menu crash right away, and even the Go one.
Product: Browser → Seamonkey
Yukinoroh Kawara: Could you still reproduce this bug with Mozilla 1.7.5 or
Mozilla 1.8 beta 1 or actual nightbuild? Could you provide Talkback incident ID?
Keywords: crash
This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/
With Seamonkey 1.0a, the problematic bookmark entry now gets displayed as

(1J) $B#T#T#W2sEz=q(B

but doesn't crash. So I'm changint the  so I guess it's okay.

This entry was most likely saved in the Netscape 4.75 era. I guess that at that
time, the browser could not convert from iso-2022-jp to Shift-JIS when saving
bookmarks, and at a later time when Mozilla tried to convert this item to UTF-8
thinking it's Shift-JIS, it cried.

I'm turning this bug into a mojibake (error conversion) problem when importing
bookmarks. I see Mozilla converted my Netscape 4.75 Shift-JIS-based bookmark
file to UTF-8 but left his one entry as is. Would there be a way for that
function to perform iso-2022-jp to UTF-8 conversion when it sees iso-2022-jp text ?

(I just tried to hit the link and save that bookmark again, the save bookmark
function performs iso-2022-jp to UTF-8 conversion.)
Severity: critical → minor
Keywords: crash
Summary: Crash in Manage Bookmarks window when rendering New-JIS text → Importing/loading bookmarks doesn't convert iso-2022-jp text to UTF-8
Whoopsie...
error conversion = character conversion

And I also notice that the text got rendered correctly in my last post... In the
bookmarks file it looks like (1J) $B#T#T#W2sEz=q(B , with escape sequences,
which is iso-2022-jp indeed.
Reassigning as per Bug #32644
Assignee: p_ch → nobody
Yukinoroh, is this still a valid bug?
(1 month later)

No (more) reply from reporter.

SeaMonkey v1.0.x is not supported anymore.

(Would have been "Incomplete", now is) R.Invalid

Reopen if you can reproduce with SeaMonkey v1.1.9.
Status: UNCONFIRMED → RESOLVED
Closed: 16 years ago
Resolution: --- → INVALID
Version: Trunk → SeaMonkey 1.0 Branch
You need to log in before you can comment on or make changes to this bug.