23355 - Enable Keywords needs to be hooked up in PrefUI

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P1)

Description

[sairuh (rarely reading bugmail)]

However, a bug needs to be filed to have the Enable Keywords item actually work,
another bug from paulmac... am presuming that keyword.enable should go into the
prefs.js file --but correct me if am wrong.

"The pref is called keyword.enabled and will be set to true by default. The
comma-separated list pref will probably not be in for beta, a bug should be
filed to track this. This will be an ugly one, because I don't think keywords
will be enabled for the mozilla product, just commercial."

Comment 1

[Paul MacQuiddy]

This is a bug to hook it up in the Pref UI. Bug 23211 deals with turning it on
by default, which jud has.

Comment 2

[don]

We probably need this for beta1 ...

Comment 3

[leger]

Putting on PDT+ radar for beta1.

Comment 4

[matt]

I have a fix for this that jud reviewed.

Index: pref-smart_browsing.xul
===================================================================
RCS file: 
/cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-smart_browsin
g.xul,v
retrieving revision 1.18
diff -r1.18 pref-smart_browsing.xul
88c88
<               pref="true" preftype="bool" 
prefstring="browser.goBrowsing.enabled"/>
---
>               pref="true" preftype="bool" prefstring="keyword.enabled"/>

Comment 5

[matt]

fixed

Comment 6

[Paul MacQuiddy]

so just to be clear, the pref should show up in both mozilla and netscape 
builds, but should be off (unchecked) in mozilla and on (checked) in netscape?

Comment 7

[matt]

You are correct my friend.

Comment 8

[sairuh (rarely reading bugmail)]

looks fine. verif w/linux comm bits, 2000-02-09-08.

Comment 9

[sairuh (rarely reading bugmail)]

oops: forgot to check: yes, on the comm builds for mac and win, the Enabled
Keywords is selected. and all platforms using the non-comm mozilla bits (and a
new/default profile), that checkbox is *not* selected.

Comment 10

[leger]

Bulk moving Pref UI bugs to new component Preferences.

Comment 11

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/1cf2ccea9ca5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23355 - Tint mozac_ic_check to white in checkbox_item.xml