233587 - small nsImageFrame cleanup

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

GetAnchorHREFAndTarget can just use nsILink instead of nsIDOMHTMLAnchorElement,
with the advantage that it gives back an nsIURI*.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: diff -w

for easier reviewing, diff -w version of the above patch

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 140992 [details] [diff] [review]
patch

>Index: nsImageFrame.h

>+  // Not virtual, since nsImageFrame is no nsLeafFrame.
>+  void GetDesiredSize(nsIPresContext* aPresContext,
>+                      const nsHTMLReflowState& aReflowState,
>+                      nsHTMLReflowMetrics& aDesiredSize);

Hmm... leave this virtual, please?  In case a subclass needs to override?

r+sr=bzbarsky with that.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

ok, checked in, and left that function virtual.