Closed Bug 233587 Opened 21 years ago Closed 21 years ago

small nsImageFrame cleanup

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.7alpha

People

(Reporter: Biesinger, Assigned: Biesinger)

Details

Attachments

(2 files)

GetAnchorHREFAndTarget can just use nsILink instead of nsIDOMHTMLAnchorElement,
with the advantage that it gives back an nsIURI*.
Attached patch diff -wSplinter Review
for easier reviewing, diff -w version of the above patch
Attachment #140992 - Flags: superreview?(bzbarsky)
Attachment #140992 - Flags: review?(bzbarsky)
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.7alpha
Comment on attachment 140992 [details] [diff] [review]
patch

>Index: nsImageFrame.h

>+  // Not virtual, since nsImageFrame is no nsLeafFrame.
>+  void GetDesiredSize(nsIPresContext* aPresContext,
>+                      const nsHTMLReflowState& aReflowState,
>+                      nsHTMLReflowMetrics& aDesiredSize);

Hmm... leave this virtual, please?  In case a subclass needs to override?

r+sr=bzbarsky with that.
Attachment #140992 - Flags: superreview?(bzbarsky)
Attachment #140992 - Flags: superreview+
Attachment #140992 - Flags: review?(bzbarsky)
Attachment #140992 - Flags: review+
ok, checked in, and left that function virtual.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: