Closed Bug 233647 Opened 21 years ago Closed 20 years ago

"Mozilla Keyboard Shortcuts" doesn't cover Solaris

Categories

(SeaMonkey :: Help Documentation, defect)

x86
Solaris
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: leon.sha, Assigned: leon.sha)

Details

Attachments

(1 file, 3 obsolete files)

In the Mozilla online help in Mozilla 1.4 beta for Solaris, the Mozilla 
Keyboard Shortcuts section has charts listing the keyboard shortcuts for
Windows, Macintosh, and Linux, but not Solaris.
Suggest to modify Linux to Linux/Unix
Attached patch Patch for help (obsolete) — Splinter Review
Comment on attachment 141033 [details] [diff] [review]
Patch for help

Neil, can you help to review this patch.
Attachment #141033 - Flags: review?(neil.parkwaycc.co.uk)
Assignee: rlk → leon.sha
Component: Help → User
Product: Browser → Documentation
Version: Trunk → unspecified
Comment on attachment 141033 [details] [diff] [review]
Patch for help

I think these should be rewritten to look like a list i.e. "(Windows, Linux,
Unix)" or "Mac OS, Linux or Unix".
Also,I actually prefer to use "or" to connect the alternatives, rather than
"and" which is currently used in some cases, but you should double-check with
rj_keller.
Attachment #141033 - Flags: review?(neil.parkwaycc.co.uk) → review-
> I think these should be rewritten to look like a list i.e. "(Windows, Linux,
> Unix)" or "Mac OS, Linux or Unix".

I assume you mean the Keyboard shortcuts. What do you mean like a list? You mean
going from Windows down to Linux for all the shortcuts? I wouldn't like that
format too much.

> Also,I actually prefer to use "or" to connect the alternatives, rather than
> "and" which is currently used in some cases

What do you mean by "or", Neil? You mean using "or" instead of a slash?
The slash for both - I just don't like seeing Linux/Unix everywhere.
Instead of "Windows and Linux/Unix" I prefer "Windows, Linux or Unix".
(In reply to comment #4)
> > I think these should be rewritten to look like a list i.e. "(Windows, Linux,
> > Unix)" or "Mac OS, Linux or Unix".
> 
> I assume you mean the Keyboard shortcuts. What do you mean like a list? You mean
> going from Windows down to Linux for all the shortcuts? I wouldn't like that
> format too much.

I think neil want to list the shortcuts for unix with a seperate column.
New patch with neil's comments.
Attachment #141295 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 141295 [details] [diff] [review]
Change linux/unix to linux or unix

Almost there...

>-Mac OS and Linux. </p>
>+Mac OS and Linux or Unix. </p>
These should say "Mac OS, Linux or Unix." The same idea would apply to
"Windows, Linux or Unix."

>+<p><strong>Note:</strong> This feature is not available on Linux or Unix &amp; Mac.</p>
rj_keller, I noticed we're not consistent here, sometimes we use Macintosh OS,
sometimes Mac OS, and this one just says Mac. Should we stick to Mac OS?
leon.sha, in that case this would say "Mac OS, Linux or Unix" too.
Attachment #141295 - Flags: review?(neil.parkwaycc.co.uk) → review-
> rj_keller, I noticed we're not consistent here, sometimes we use Macintosh OS,
> sometimes Mac OS, and this one just says Mac. Should we stick to Mac OS?

We should use Mac OS because Mac seems to refer to the platform more than the OS
(which is what we're listing).

There's a lack of consistency in many areas of the Help Viewer.
Attached patch Patch with neil's comments (obsolete) — Splinter Review
Attachment #141033 - Attachment is obsolete: true
Attachment #141295 - Attachment is obsolete: true
Attachment #141494 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 141494 [details] [diff] [review]
Patch with neil's comments

> <p><b>Note</b>: Some Page Setup functions are different or unavailable on Mac OS
>-and Linux. </p>
>+, Linux or Unix. </p>
Just one tiny nit (well, it happens in two files) - this displays as:
Mac OS , Linux or Unix
Please can you change these lines to:
<p><b>Note</b>: Some Page Setup functions are different or unavailable on
Mac OS, Linux or Unix. </p>
Attachment #141494 - Flags: review?(neil.parkwaycc.co.uk) → review+
Neil, can you tell me who is the sr of this module?
Attachment #141494 - Attachment is obsolete: true
Help text doesn't need sr; you can just check it in when the tree reopens.
Comment on attachment 141523 [details] [diff] [review]
Patch with neil's comments.

Leon, I don't require Help Text to be super-reviewed unless it was a major
layout change of some sort. XUL and JS changes would be done by the same sr's
as the XPApps module (alecf or jag would probably be best).

r=rlk@trfenv.com, let's try and get 1.7a approval for this (it's small, so why
not?).
Attachment #141523 - Flags: review+
--> Help, for flags.
Component: User → Help
Product: Documentation → Browser
Version: unspecified → Trunk
Attachment #141523 - Flags: approval1.7a?
Comment on attachment 141523 [details] [diff] [review]
Patch with neil's comments.

a=chofmann for 1.7a
Attachment #141523 - Flags: approval1.7a? → approval1.7a+
Fix checked in.

Thanks for the patch, Leon!
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Reopening since the current composer_help file lacks changes made after
revision 1.14. This will be fixed by the patch in bug 210335.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
--> Fixed
Status: REOPENED → RESOLVED
Closed: 21 years ago20 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: