"Mozilla Keyboard Shortcuts" doesn't cover Solaris

RESOLVED FIXED

Status

RESOLVED FIXED
15 years ago
14 years ago

People

(Reporter: leon.sha, Assigned: leon.sha)

Tracking

Trunk
x86
Solaris

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

15 years ago
In the Mozilla online help in Mozilla 1.4 beta for Solaris, the Mozilla 
Keyboard Shortcuts section has charts listing the keyboard shortcuts for
Windows, Macintosh, and Linux, but not Solaris.
Suggest to modify Linux to Linux/Unix
(Assignee)

Comment 1

15 years ago
Created attachment 141033 [details] [diff] [review]
Patch for help
(Assignee)

Comment 2

15 years ago
Comment on attachment 141033 [details] [diff] [review]
Patch for help

Neil, can you help to review this patch.
Attachment #141033 - Flags: review?(neil.parkwaycc.co.uk)

Updated

15 years ago
Assignee: rlk → leon.sha
Component: Help → User
Product: Browser → Documentation
Version: Trunk → unspecified

Comment 3

15 years ago
Comment on attachment 141033 [details] [diff] [review]
Patch for help

I think these should be rewritten to look like a list i.e. "(Windows, Linux,
Unix)" or "Mac OS, Linux or Unix".
Also,I actually prefer to use "or" to connect the alternatives, rather than
"and" which is currently used in some cases, but you should double-check with
rj_keller.
Attachment #141033 - Flags: review?(neil.parkwaycc.co.uk) → review-

Comment 4

15 years ago
> I think these should be rewritten to look like a list i.e. "(Windows, Linux,
> Unix)" or "Mac OS, Linux or Unix".

I assume you mean the Keyboard shortcuts. What do you mean like a list? You mean
going from Windows down to Linux for all the shortcuts? I wouldn't like that
format too much.

> Also,I actually prefer to use "or" to connect the alternatives, rather than
> "and" which is currently used in some cases

What do you mean by "or", Neil? You mean using "or" instead of a slash?

Comment 5

15 years ago
The slash for both - I just don't like seeing Linux/Unix everywhere.
Instead of "Windows and Linux/Unix" I prefer "Windows, Linux or Unix".
(Assignee)

Comment 6

15 years ago
(In reply to comment #4)
> > I think these should be rewritten to look like a list i.e. "(Windows, Linux,
> > Unix)" or "Mac OS, Linux or Unix".
> 
> I assume you mean the Keyboard shortcuts. What do you mean like a list? You mean
> going from Windows down to Linux for all the shortcuts? I wouldn't like that
> format too much.

I think neil want to list the shortcuts for unix with a seperate column.
(Assignee)

Comment 7

15 years ago
Created attachment 141295 [details] [diff] [review]
Change linux/unix to linux or unix

New patch with neil's comments.
(Assignee)

Updated

15 years ago
Attachment #141295 - Flags: review?(neil.parkwaycc.co.uk)

Comment 8

15 years ago
Comment on attachment 141295 [details] [diff] [review]
Change linux/unix to linux or unix

Almost there...

>-Mac OS and Linux. </p>
>+Mac OS and Linux or Unix. </p>
These should say "Mac OS, Linux or Unix." The same idea would apply to
"Windows, Linux or Unix."

>+<p><strong>Note:</strong> This feature is not available on Linux or Unix &amp; Mac.</p>
rj_keller, I noticed we're not consistent here, sometimes we use Macintosh OS,
sometimes Mac OS, and this one just says Mac. Should we stick to Mac OS?
leon.sha, in that case this would say "Mac OS, Linux or Unix" too.
Attachment #141295 - Flags: review?(neil.parkwaycc.co.uk) → review-

Comment 9

15 years ago
> rj_keller, I noticed we're not consistent here, sometimes we use Macintosh OS,
> sometimes Mac OS, and this one just says Mac. Should we stick to Mac OS?

We should use Mac OS because Mac seems to refer to the platform more than the OS
(which is what we're listing).

There's a lack of consistency in many areas of the Help Viewer.
(Assignee)

Comment 10

15 years ago
Created attachment 141494 [details] [diff] [review]
Patch with neil's comments
Attachment #141033 - Attachment is obsolete: true
Attachment #141295 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #141494 - Flags: review?(neil.parkwaycc.co.uk)

Comment 11

15 years ago
Comment on attachment 141494 [details] [diff] [review]
Patch with neil's comments

> <p><b>Note</b>: Some Page Setup functions are different or unavailable on Mac OS
>-and Linux. </p>
>+, Linux or Unix. </p>
Just one tiny nit (well, it happens in two files) - this displays as:
Mac OS , Linux or Unix
Please can you change these lines to:
<p><b>Note</b>: Some Page Setup functions are different or unavailable on
Mac OS, Linux or Unix. </p>
Attachment #141494 - Flags: review?(neil.parkwaycc.co.uk) → review+
(Assignee)

Comment 12

15 years ago
Created attachment 141523 [details] [diff] [review]
Patch with neil's comments.

Neil, can you tell me who is the sr of this module?
Attachment #141494 - Attachment is obsolete: true

Comment 13

15 years ago
Help text doesn't need sr; you can just check it in when the tree reopens.

Comment 14

15 years ago
Comment on attachment 141523 [details] [diff] [review]
Patch with neil's comments.

Leon, I don't require Help Text to be super-reviewed unless it was a major
layout change of some sort. XUL and JS changes would be done by the same sr's
as the XPApps module (alecf or jag would probably be best).

r=rlk@trfenv.com, let's try and get 1.7a approval for this (it's small, so why
not?).
Attachment #141523 - Flags: review+

Comment 15

15 years ago
--> Help, for flags.
Component: User → Help
Product: Documentation → Browser
Version: unspecified → Trunk

Updated

15 years ago
Attachment #141523 - Flags: approval1.7a?

Comment 16

15 years ago
Comment on attachment 141523 [details] [diff] [review]
Patch with neil's comments.

a=chofmann for 1.7a
Attachment #141523 - Flags: approval1.7a? → approval1.7a+

Comment 17

15 years ago
Fix checked in.

Thanks for the patch, Leon!
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Updated

15 years ago
Status: RESOLVED → VERIFIED

Comment 18

14 years ago
Reopening since the current composer_help file lacks changes made after
revision 1.14. This will be fixed by the patch in bug 210335.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---

Comment 19

14 years ago
--> Fixed
Status: REOPENED → RESOLVED
Last Resolved: 15 years ago14 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.