Closed Bug 233657 Opened 20 years ago Closed 20 years ago

(win) nsSound::OnStreamComplete comment is wrong and function is not oom friendly

Categories

(Core Graveyard :: GFX: Win32, defect)

Product:
Core Graveyard
Component:
GFX: Win32
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file)

sync comment and sync player for oom
1.00 KB, patch
neil
: review+
tor
: superreview+
Details | Diff | Splinter Review 
145 pavlov   1.10   if (string && stringLen > 0) {
146                   // XXX this shouldn't be SYNC, but unless we make a copy
of the memory, we can't play it async.
147                   // We shouldn't have to hold on to this and free it.

148 hyatt    1.19     mLastSound = (char *) malloc(stringLen);
149                   memcpy(mLastSound, string, stringLen);

150 pavlov   1.24 
151                   CWinMM& theMM = CWinMM::GetModule();
152                   theMM.PlaySound(mLastSound, nsnull, SND_MEMORY |
SND_NODEFAULT | SND_ASYNC);

153 syd      1.7    }

Actual blame for the async change lies w/ hyatt.

    
  

        Attachment #141038 -
        Flags: review?(neil.parkwaycc.co.uk)

    
    

    
  
Comment on attachment 141038 [details] [diff] [review]
sync comment and sync player for oom

r=me if you include a reminder to improve this when strings become sharable.

        Attachment #141038 -
        Flags: review?(neil.parkwaycc.co.uk) → review+

    
  

        Attachment #141038 -
        Flags: superreview?(tor)

    
  

        Attachment #141038 -
        Flags: superreview?(tor) → superreview+

    
    

    
  
mozilla/widget/src/windows/nsSound.cpp 	1.33
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.