233667 - cannot build with gcc 3.3.2, problem with nsCharTraits.h or nsBufferHandle.h

Status: RESOLVED EXPIRED

(Core :: XPCOM, defect)

Description

[£ukasz Mach]

User-Agent:       
Build Identifier: http://ftp.mozilla.org/pub/mozilla.org/thunderbird/releases/0.5/thunderbird-0.5-source.tar.bz

When I build thunderbird, I got error messages "ISO C++ forbids declaration ....
without a type" in nsCharTraits.h:381

I looked there, and template declaration which is in that line doesn't seem to
be wrong. I copied it to temporary c++ file, tried to compile and success. But
that declaration makes error while built in mozilla context. 

I made a little investigation and if enclose nsBufferHandle.h with #if 0/#endif,
that error disappeares. of course it made lot of other errors, but totally
different that "ISO C++ forbids.....". I don't know what in nsBufferHandle.h may
be wrong, I even don't know if it's really source of problems.....

Reproducible: Always
Steps to Reproduce:
1. export variables: MOZ_THUNDERBIRD=1, MOZILLA_OFFICIAL=1, BUILD_OFFICIAL=1
2. prepare .mozconfig
3. make -f client.mk build

Actual Results:  
such output:
make[5]: Wejście do katalogu `/home/users/maho/rpm/BUILD/mozilla/xpcom/string/src'
nsASingleFragmentString.cpp
c++ -o nsASingleFragmentString.o -c -DOSTYPE=\"Linux2.6\" -DOSARCH=\"Linux\"
-D_IMPL_NS_COM  -I../../../dist/include/xpcom -I../../../dist/include/string
-I../../../dist/include -I/home/users/maho/rpm/BUILD/mozilla/dist/include/nspr 
   -I/usr/X11R6/include   -fPIC  -I/usr/X11R6/include -fno-rtti -fno-exceptions
-Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth
-Wno-ctor-dtor-privacy -Wno-long-long -pedantic -fshort-wchar -pthread -pipe 
-DNDEBUG -DTRIMMED -ffunction-sections  -I/usr/X11R6/include -DMOZILLA_CLIENT
-include ../../../mozilla-config.h -Wp,-MD,.deps/nsASingleFragmentString.pp
nsASingleFragmentString.cpp
In file included from ../../../dist/include/string/nsAString.h:36,
                 from ../../../dist/include/string/nsASingleFragmentString.h:30,
                 from nsASingleFragmentString.cpp:24:
../../../dist/include/string/nsCharTraits.h:381: error: ISO C++ forbids
   declaration of `difference_type' with no type
../../../dist/include/string/nsCharTraits.h:381: error: `::difference_type' is
   not a valid declarator
../../../dist/include/string/nsCharTraits.h:381: error: parse error before `;'
   token
../../../dist/include/string/nsCharTraits.h:407: error: ISO C++ forbids
   declaration of `value_type' with no type
../../../dist/include/string/nsCharTraits.h:407: error: `::value_type' is not a
   valid declarator
../../../dist/include/string/nsCharTraits.h:407: error: parse error before `*'
   token
../../../dist/include/string/nsCharTraits.h:415: error: type specifier omitted
   for parameter `difference_type'
../../../dist/include/string/nsCharTraits.h:415: error: parse error before `)'
   token
../../../dist/include/string/nsCharTraits.h:416: error: ISO C++ forbids
   defining types within return type
../../../dist/include/string/nsCharTraits.h:416: error: two or more data types
   in declaration of `advance'
../../../dist/include/string/nsCharTraits.h:416: error: semicolon missing after
   declaration of `struct nsCharSourceTraits<InputIterator>'
../../../dist/include/string/nsCharTraits.h:419: error: parse error before `}'
   token
../../../dist/include/string/nsCharTraits.h:471: error: non-template type `
   nsCharSourceTraits' used as a template
../../../dist/include/string/nsCharTraits.h:472: confused by earlier errors,
bailing out
make[5]: *** [nsASingleFragmentString.o] B&#322;&#261;d 1
make[5]: Opuszczenie katalogu `/home/users/maho/rpm/BUILD/mozilla/xpcom/string/src'
make[4]: *** [libs] B&#322;&#261;d 2
make[4]: Opuszczenie katalogu `/home/users/maho/rpm/BUILD/mozilla/xpcom/string'
make[3]: *** [libs] B&#322;&#261;d 2
make[3]: Opuszczenie katalogu `/home/users/maho/rpm/BUILD/mozilla/xpcom'
make[2]: *** [tier_2] B&#322;&#261;d 2
make[2]: Opuszczenie katalogu `/home/users/maho/rpm/BUILD/mozilla'
make[1]: *** [default] B&#322;&#261;d 2
make[1]: Opuszczenie katalogu `/home/users/maho/rpm/BUILD/mozilla'
make: *** [build] B&#322;&#261;d 2


Expected Results:  
should build properly I think so :)

Comment 1

[cls]

I think darin's string changes have landed since thunderbird 0.5.  Can you
reproduce the build problem with a current trunk tree?

Comment 2

[£ukasz Mach]

I don't remember correctly, but at least I built it, but not from release
tarball, but from CVS with proper tag. I didn't more investigation, but I think
that release tarball was/is broken. 

Comment 3

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 4

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.