233753 - GetDefaultNamespaceID creates does not return XHTML in HTML documents

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bob Clary [:bc] (inactive)]

Chatzilla and the DOM TS were broken due to the creation of XML Elements when
calling document.createElement('tagname') from HTML Documents. This was
introduced in bug 16603.

jst has a patch.

Comment 1

[Bob Clary [:bc] (inactive)]

err. correct summary.

Comment 2

[Johnny Stenback (:jst)]

Attachment: Make the default namespace of HTML documents be kNameSpaceID_XHTML

This makes document.createElement('foo') create an HTML element again if
document is an HTML document.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Hmm... What will the namespace in the nodeinfo of the new node be then?

Comment 4

[Johnny Stenback (:jst)]

Wrong. And dbaron pointed that out to me too. New patch coming up. I'm basically
reverting to the old CreateElement() code in nsHTMLDocument... Got too excited
there when I figured out what was breaking everything :-)

Comment 5

[Johnny Stenback (:jst)]

Attachment: Revert nsHTMLDocument::CreateElement() to what it used to be, more or less.

This should get it right, in all cases AFAICT.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 141112 [details] [diff] [review]
Revert nsHTMLDocument::CreateElement() to what it used to be, more or less.

r=bzbarsky

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 141112 [details] [diff] [review]
Revert nsHTMLDocument::CreateElement() to what it used to be, more or less.

sr=dbaron, although it's worth noting (for the future) that you might want to
be doing the case conversion before converting to UTF-8.

Comment 8

[Johnny Stenback (:jst)]

Fix checked in, and I went ahead and changed the |tmp| string to an nsAutoString
and called ToLowerCase() on it, and let the atom code to the UTF8 conversion.
Slightly slower, but correct, and this is not on a performance critical path.

Thanks for the reviews, marking FIXED.

Comment 9

[Boris Zbarsky [:bzbarsky]]

So.. this patch actually makes us violate both DOM2 Core and DOM3 Core...  See
bug 280692.