233960 - nsContextMenuInfo should not use nsIPresContext::LoadImage

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Embedding: APIs, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

/embedding/browser/webBrowser/nsContextMenuInfo.cpp, line 286 -- rv =
presContext->LoadImage(bg->mBackgroundImage, pBGFrame,
getter_AddRefs(mCachedBGImageRequest));
/embedding/browser/webBrowser/nsContextMenuInfo.cpp, line 318 -- rv =
presContext->LoadImage(bg->mBackgroundImage, pBGFrame,
getter_AddRefs(mCachedBGImageRequest));

there must be a better way to do this... possibly by getting computed style and
asking imgILoader to load the image, or something.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Or just using the URI as you do, but asking imgLoader to load the image, even. 
nsPresContext::LoadImage is scheduled to be axed as soon as we can manage, and
it would be nice to not have this caller to deal with.

Though not relying on all that stuff about frames and such would be nice (eg the
context menu in xpfe manages to get the URI without any of this and relying only
on scriptable interfaces.....)

Comment 2

[Benjamin Smedberg]

Marking a bunch of bugs in the "Embedding: APIs" component INCOMPLETE in preparation to archive that component. If I have done this incorrectly, please reopen the bugs and move them to a more correct component as we don't have "embedding" APIs any more.