Composer->File menu has two menuitems (Publish and Page Setup) with the same hot key ''u".

RESOLVED FIXED

Status

SeaMonkey
Composer
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: Sachin, Assigned: timeless)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.13 KB, patch
neil@parkwaycc.co.uk
: review+
dbaron
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

14 years ago
User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.6) Gecko/20040113

In the "File" menu of COMPOSER, both "Publish" and "Page Setup" menu items have
the same hot key "u". Pressing "u" selects "Publish" menu item and doesnot open
the "Page Setup" dialog box. 

Reproducible: Always
Steps to Reproduce:
1. Open Composer.
2. Select "File" menu. 
3. Press "u" to open "Page Setup" dialog box. 
Actual Results:  
"Publish" menu item gets focus.

Expected Results:  
"Page Setup" dialog box should be opened as it has "u" as its hotkey.
(Reporter)

Comment 1

14 years ago
The problem is not seen in MOZ 141. MOZ 141 did not have "Page Setup" menuitem
in "File" menu of Composer. It has been introduced in MOZ 1.6. Now both
"Publish" and "Page Setup" menuitems have the same hot key 'u'.  This problem
could be solved by changing the hot key of "Publish" menuitem to 'i'.  
(Reporter)

Comment 2

14 years ago
Created attachment 141308 [details] [diff] [review]
Patch for Review

Updated

14 years ago
Assignee: composer → ssachinr
(Reporter)

Updated

14 years ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 3

14 years ago
i think we should consider giving publish 'b' and giving publish as 'i'...

Comment 4

14 years ago
"i" isn't a good access key... perhaps we could use "h" and bump Save As Charset
to use "v" instead?

Comment 5

14 years ago
This has to go in today to be translated!
(Assignee)

Comment 6

14 years ago
Re_vert is using v. I'd say drop "u" from Publish. people in a hurry can use the
command sequence.

Comment 7

14 years ago
(In reply to comment #6)
>Re_vert is using v.
Ah, ok... I think "d" is still free...
(Reporter)

Comment 8

14 years ago
'i' is used as an access key for Edit->Properties menuitem of Address Book. It
is visible and doesnot look odd. I believe we can go ahead with 'i' as the
access key for File->Publish menuitem in the composer.
(Assignee)

Comment 9

14 years ago
Created attachment 143502 [details] [diff] [review]
musical chairs

"Publish": "u">"b"
"Publish As...": "b">"h"
"Save And Change Character Encoding": "h">"E"

"Send Page...": "g">"d"

This last one is future proofing.

Note that we still don't have a "Print Preview" menuitem.
Assignee: ssachinr → timeless
Attachment #141308 - Attachment is obsolete: true

Updated

14 years ago
Attachment #143502 - Flags: review+
(Assignee)

Updated

14 years ago
Attachment #143502 - Flags: superreview?(dbaron)
Comment on attachment 143502 [details] [diff] [review]
musical chairs

sr=dbaron if Daniel is ok with this
Attachment #143502 - Flags: superreview?(dbaron) → superreview+
(Assignee)

Comment 11

14 years ago
Comment on attachment 143502 [details] [diff] [review]
musical chairs

neil and i are both peers to editor, our decissions should be sufficient.
ignoring that, we did discuss this on #composer with glazou and he made it
clear that this was not even close to being on his list of concerns. he did not
express any concern at that time.
Attachment #143502 - Flags: approval1.7b?
timeless is right here. I followed the thread and had no comment to make.
this implies moa=daniel@glazman.org

Comment 13

14 years ago
Comment on attachment 143502 [details] [diff] [review]
musical chairs

a=chofmann for 1.7b
Attachment #143502 - Flags: approval1.7b? → approval1.7b+

Comment 14

14 years ago
timeless checked in his patch, so marking fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.