23440 - Bulk move/delete produces dangerous bogus message

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[Richard Zach]

Selecting more than one message and moving them to a local mail folder produces
a bogus message in the target folder.  The message is not in the corresponding
mbox file, but rather apparently only an entry in the corresponding .msf file.
The message has a time stamp of 12/31/69, 04:00, empty subject and sender,
marked unread.

Select the message and the following happens: Mozilla freezes, load monitor
indicates CPU activity and the harddrive is active.  After approx 10-15 seconds,
memory usage increases rapidly, until swap space is full, at which point the X
server dies.

Linux build 2000.01.08.08

Comment 1

[Phil Peterson]

Reassign to jefft, cc bienvenu

Comment 2

[David :Bienvenu]

I'm in this area; I'll look at it.

Comment 3

[David :Bienvenu]

accepting

Comment 4

[David :Bienvenu]

I can't reproduce anything remotely like this - is it a particular set of
messages, or any time you move a message to a local folder?

Comment 5

[Richard Zach]

It happens with any two or more messages I move to a local folder.

Here's what I did:
1. Manually deleted Local Mail/Drafts folder to make sure it's empty
2. Start MailNews
3. Save two test messages as Drafts
4. File | New Folder "Local Mail/Test"
5. Select the two test messages and move them to Test folder.

I'll attach the contents of theDrafts folder before the move, the contents of
the Test folder after the move, and the test.msf file.  Notice that Test
contains two identical copies of the same message.

All this using 2000.01.11.09 Linux build.

Comment 6

[Richard Zach]

Attachment: Drafts folder before move

Comment 7

[Richard Zach]

Attachment: Test folder after move

Comment 8

[Richard Zach]

Attachment: Test.msf after move

Comment 9

[David :Bienvenu]

so this is a move from one local folder to another, and messages were put in the
local folder by the drafts code? If so, I'm giving this back to jeff. I thought
IMAP was involved.

Comment 10

[Richard Zach]

No, it doesn't look to me like its IMAP-related.  When I bulk move messages from
an IMAP folder, I don't get the weird message entry, but the first selected
message shows up twice in the target folder.  On bulk moves from local (or POP)
folders, the message shows up twice in the target folder, but the header of one
of the duplicates is displayed as initially described, plus the crash when you
click on it.  Also, the weird header will sometimes be gone after your restart
Mozilla.  (If you copy the attachments to this bug to your Mail diretory, all
you'll see is the duplicate message, not the weird message).  The duplicate
message doesn't seem to happen when the messages selected are not adjacent in
the thread display (or the mbox?).

To summarize: Select two or more adjacent messages by Shift-Click selecting and
Message | Move to a local folder produces an extra copy of the first selected
message.  Moving from a local folder screws up the header of one of the two
duplicate messages, and selecting that message causes a crash.

Comment 11

[jefft]

Looks like shift-click on Linux does not report correct selected items from the
tree. Windows work fine.

Comment 12

[jefft]

We have one extra selection coming back from tree.selectedItem. For example, two
messages in a folder. Shift-click the two messages. The tree.selectedItems
lenght() returns 3 instead of 2.

selmer, alecf said that you would be the person to take this bug. I am
reassigning this bug to you. Thanks,

Comment 13

[leger]

Moving bug to hyatt per pdt mtg....are you right person?

Comment 14

[David Hyatt]

Ummm... I just got this tonight.  

Is this considered an M13 show-stopper, or can I just move it off to M14?  I 
have rewritten shift+click selection in my tree, and it probably fixes the bug, 
but I haven't really shaken it out yet.

Comment 15

[David Hyatt]

Well, it seems to be working more or less ok on my machine.  If you're willing 
to take the risk, I'm willing to check it in.

waterson and alecf: care to do a review?

Comment 16

[David Hyatt]

Moving to M14.  I don't want to rush this fix.

Comment 17

[Ben Bucksch (:BenB)]

Can't we avoid at least the bad results of this bug (mem and cpu usage) for M13
by making more checks on the mailnews side (folder/database)?

This line in the attached folder looks very suspicious:
From - Wed Jan 12 From - Wed Jan 12 18:02:20 2000

Comment 18

[Alec Flett]

I'll bet this is just a dupe of your shift-click bug.
Personally, I think this is release-notable.

Comment 19

[David Hyatt]

Fixed.

Comment 20

[fenella]

Win_nt 4.0 (2000-01-25-20 M13)
Linux  (2000-01-25-20 M13)
Mac (2000-01-26-03 M13)
These  two problems described originally still exists: 

Problem 1. Select two or more adjacent messages (in IMAP) by Shift-Click
selecting and
Message | Move to a local folder produces an extra copy of the first selected
message.  Notice that the target folder contains two identical copies of  the
first source message.

Problem 2. Select two or more adjacent messages (in Local folder) by Shift-Click
selecting and and Moving to a local folder.  Notice that the target folder
contains an extra copy of header which has a time stamp of 12/31/69, 04:00,
empty subject and sender, marked unread..
However, selecting the first empty subject thread does not produce crash.

If you want me to close this one and re-write two new bugs, please let me know.

These problems occur on all platforms.

Comment 21

[fenella]

Linux (2000-01-26-09 M14)
Win32 (2000-01-26-10 M14)
Mac (2000-01-26-14 M14)
Since this bug has been fixed in M14.  I am going to mark it fixed and close it.

Comment 22

[fenella]

Mark it verified.

Comment 23

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/6b920554a37a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23440,https://github.com/mozilla-mobile/fenix/issues/23441,https://github.com/mozilla-mobile/fenix/issues/23442 remove adapting themes after switching wallpapers