Closed Bug 234442 Opened 20 years ago Closed 20 years ago
'mozilla' hardcoded into application install paths
When using 'make install' to install the franken-gecko apps, the apps overwrite each other because the mozappdir contains a hardcoded mozilla name. mozappdir is where all of the components are installed. As long as the apps share a common build system, there needs to be a way (--enable-app-name ?) to specific which app we are building for 'make install'. Other things that would need to be properly versioned are the includedir and the pkgconfig files. Bug 228866 may have been caused by this problem.
Here's the preliminary patch which adds --with-moz-appname to configure. This lets us set the name which is used when packaging the build whether using 'make install' or 'make -C xpinstall/packager'. The one thing I don't like about this patch is that you wind up with paths like, /usr/lib/firefox-1.7a . The application version number should probably be configurable as well but right now MOZILLA_VERSION is tied into the locale version which shouldn't revert to 0.8a just because we're building firefox.
Took a different approach. Rather that adding another configure option, just base the appname & version off of the env variables which are required to build each app.
Attachment #141626 - Attachment is obsolete: true
Attachment #142070 - Flags: review?(bryner) → review+
Patch has been checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.7beta
(In reply to comment #3) > Patch has been checked in. how to set the env variables? I did a regular exports at the command line and I get this /usr/lib/@MOZ_APP_NAME@-@MOZ_APP_VERSION@# not the /usr/lib/firefox-0.8 as I wanted it to be. I did this before I did the make export MOZ_APP_NAME=firefox export MOZ_APP_VERSION=0.8
You don't set them manually. You apply the patch, run autoconf 2.13 in the mozilla directory then build as normal.
You need to log in before you can comment on or make changes to this bug.