234463 - double-clicking empty event list area opens malfunctioning Edit Event dialog

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Joe Infla]

Mozilla 2004021508, calendar build 2004-01-23, winxp

With a full event list, double-clicking in the event list area edits the clicked
event.  With a non-full event list, double-clicking in unfilled space opens an
Edit Event dialog with the following misfunctions:
a. Date is today's date regardless of the selected day.
b. Categories says "None" and lists no options in the drop-down.
c. Calendar File dropdown is empty, containing no options.
d. OK button is nonfunctional.
e. Cancel button returns to Calendar with a 'busy' mouse cursor until some
normal action is taken.  Functionality is not impaired, but the busy cursor
won't go away without user action.

Javascript Console reports the following error when the dialog appears:
Error: gEvent.start has no properties
Source File: chrome://calendar/content/eventDialog.js
Line: 141

Steps to reproduce:
1. Use an empty calendar or select some event view that leaves unused space in
the events list.
2. Double-click the empty area.

Actual: opens Edit Event dialog as described above.
Expected: Either no action, or open New Event Dialog (as I originally expected
to happen).

Comment 1

[Jussi Kukkonen]

Attachment: patch, opens a 'new event' dialog instead of broken 'edit event'

This small patch fixes the bug (getCalendarEventFromEvent returned false, null
is mor meaningful here). It also adds the functionality submitter asked for
(and which I think is correct): double-clicking on empty space opens a 'new
event' dialog.

The small change I made in calendar.js:newEvent makes some other pieces of code
redundant, I believe. I guess it's ok to post another diff here if I remove
them?

Comment 2

[Jussi Kukkonen]

(In reply to comment #1)

Seems there wasn't much redundancy on this after all ;)

calendar.js:newEventCommand could probably do with just calling newEvent()
without startDate, but I wasn't sure what was the point with gNewDateVariable,
so I didn't touch it.

The patch in comment 1 is still valid.

Comment 3

[Mostafa Hosseini]

Patch checked in.
Thanks.
Jussi: Do you by any chance manually modify the patches? I'm having a hard time
trying to tweak them to apply properly to the code.
Also it would be better not to have the DOS carriage return on each line if
possible.

Comment 4

[Jussi Kukkonen]

*** Bug 230715 has been marked as a duplicate of this bug. ***

Comment 5

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!