234614 - nohref is broken

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

nohref was initially implemented in bug 7304 but has since broken again. It
should be an easy fix but I'm not sure where the appropriate place to insert a
check for this attribute would be.

I'd like to remove all href/target/etc-aware code out of the imagemap code since
it just begs for bugs to keep it duplicated in there.

Anyone got any suggestions?

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

see also bug 234615 

Comment 2

[Boris Zbarsky [:bzbarsky]]

> It should be an easy fix but I'm not sure where the appropriate place to insert
> a check for this attribute would be.

Probably nsHTMLAreaElement::HandleDOMEvent.  It should just call
nsGenericHTMLElement::HandleDOMEvent if nohref is set.

> I'd like to remove all href/target/etc-aware code out of the imagemap code 

Where is this in imagemap code, really?  You mean the stuff in bug 234615? 
Yeah, that's gotta go.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yeah, the stuff in bug 234615 as well as the small remainder in terms of the
implementation and callers of Area::GetHREF.

I think we need it in more then just nsHTMLAreaElement::HandleDOMEvent (well,
actually nsGenericHTMLElement::HandleDOMEventForAnchors, right?) since we want to:
A) Not follow the link when clicked on
B) Not change the cursor when hovering the link

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Ah, you are indeed right, nohref is an <area> thing only so the code for it
should not live in nsGenericHTMLElement::HandleDOMEventForAnchors

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

What needs to be done here?

Comment 6

[Anne (:annevk)]

WORKSFORME per https://bugzilla.mozilla.org/attachment.cgi?id=1042.