Closed Bug 234615 Opened 20 years ago Closed 20 years ago
Minor cleanup in imagemap code
While looking into consumers of nsIHTMLContent::GetBaseTarget i found a gem in the imagemap code. nsImageMap::IsInside has a signature that returns the alt-attribute, target and href of the found <area>, however all callers of this function ignore these arguments. Incidently, the code in nsImageMap::IsInside that calculates the target is the only caller of nsIHTMLContent::GetBaseTarget. So i killed this code along with nsIHTMLContent::GetBaseTarget and with it a member in the Area-class that ended up being unused. I also fixed GetTarget in <area> and <a> to properly use the default target when the attribute isn't specified. I also noticed that the support for the nohref attribute is broken, that's filed as bug 234614.
20 years ago
Comment on attachment 141592 [details] [diff] [review] patch to fix sr=jst
Attachment #141592 - Flags: superreview?(jst) → superreview+
Attachment #141592 - Flags: review?(bryner) → review+
checked in. Thanks for reviews.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.