234665 - Delete button should re-text to "Undelete" when a deleted message is selected

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[Chris P. Ross]

User-Agent:       
Build Identifier: Thunderbird/0.5

When a deleted message is selected, the text on the "Delete" button in the top
button-bar should change to "Undelete", much the same way the "Junk" text
changes to "Not Junk" when a junk message is selected.

Reproducible: Always
Steps to Reproduce:
1. Select a deleted message

Actual Results:  
No change in the text of the "Delete" button

Expected Results:  
Should've changed the text to "Undelete", as that's the result of clicking the
button in this condition.

Comment 1

[Jason Chu]

I think the reason why it's not set to "Undelete" is because the "Delete" button
is still needed to permanently delete a message from the Trash.

Comment 2

[u63580]

*** Bug 232859 has been marked as a duplicate of this bug. ***

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #0)
> Expected Results:  
> Should've changed the text to "Undelete", as that's the result of clicking the
> button in this condition.

This only happens in the far less frequent case where someone's selected that
pressing delete only marks a message as deleted instead of having it moved to
the trash bin.

To fix this right, we'd need to only change the text of the function when that
mode is on, and IMO, it's not worth the effort/bother. Strongly suggest WONTFIX.

Comment 4

[ovidiu]

also in bug 207485, but for moz app suite (sm), very old also ..

So it's been a while now, some versions already out, is this interesting anymore? or just won't fix? as in comment 3?

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Well I don't see why we wouldn't do it. The menu items under Edit already rephrase properly. I don't think it's very unusual (though for sure a minority) for people to use the imap mark as deleted model. I do, mostly.

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 336252 [details] [diff] [review]
proposed fix

Yeesh. Given all the code we already have to change the menu, and make the Delete key the Undelete key, this makes perfect sense. I just wish we didn't have any of it...

Comment 7

[Magnus Melin [:mkmelin]]

changeset:   331:ba1576dfde33
http://hg.mozilla.org/comm-central/rev/ba1576dfde33

->FIXED