234683 - Using no value for charset detect slows down Camino by 15%

Status: RESOLVED WORKSFORME

(Core :: Internationalization, defect)

Description

[Mike Pinkerton (not reading bugmail)]

Camino used to (wrongly) run with

pref("intl.charset.detector", "universal_charset_detector");

Someone pointed out the error of our ways and i removed this line from
all-camino.js, defaulting to whatever mozilla does. At this point (and you can
see it if you look at Tp from the Pawn tinderbox in mid-Jan 2004), we took at
15% Tp hit. Just to be sure, I added the line back in this morning and we got
15% faster again.

Why are we 15% slower not doing any detection?

Comment 1

[Simon Fraser [no longer active]]

Are you sure this is the right way round. We should be faster without
"universal_charset_detector", no with it.

Comment 2

[Mike Pinkerton (not reading bugmail)]

in the past (and maybe this changed since 0.7ish), not setting
universal_charset_detector was the way to turn it on.

yes, quite confusing, but that was what we did.

Comment 3

[Henri Sivonen (:hsivonen)]

The detector has been rewritten.