File format filter should be shown to user ("All Files (*.*)")

NEW

Status

SeaMonkey
UI Design
--
trivial
19 years ago
10 years ago

People

(Reporter: Henrik Gemal, Assigned: jag (Peter Annema))

Tracking

(Blocks: 1 bug)

Trunk
x86
Windows 98

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

19 years ago
In the open dialog in Mozilla, both in the browser, mail/news, etc, the File
Type description of All Files should "All Files (*.*)" in stead of just "All
Files"

Places to changes:
http://lxr.mozilla.org/seamonkey/search?string=%22All+Files%22

Comment 1

19 years ago
[reducing severity to Enhancement Request.]

...of course, such a change should only be made if it can be done without
affecting the Mac builds, as Mac users don't use foobar.baz styled file names.
Severity: normal → enhancement
Summary: "All Files" should be "All Files (*.*)" → [enh] "All Files" should be "All Files (*.*)"

Updated

19 years ago
Status: NEW → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → WONTFIX

Comment 2

19 years ago
agreed. reset the bug to "won't fix".

Updated

19 years ago
Status: RESOLVED → REOPENED

Comment 3

19 years ago
Err...rather, gemal's suggestion is how other Windows applications work --- so
we should be doing it the same way, right? We just need to be sure that it's
only changed on the Windows platform.

Re-opening, and assigning to Don.

Updated

19 years ago
Assignee: shuang → don
Status: REOPENED → NEW

Updated

19 years ago
Resolution: WONTFIX → ---

Comment 4

19 years ago
Reassigned to Don.
(Reporter)

Comment 5

19 years ago
Also remember that in the File Upload dialog it's:
"all files" and not "All Files"

Updated

19 years ago
Severity: enhancement → trivial
Summary: [enh] "All Files" should be "All Files (*.*)" → "All Files" should be "All Files (*.*)"
Target Milestone: M19

Comment 6

19 years ago
This isn't an RFE.  We're just not following the UI guidelines. :-)

Comment 7

19 years ago
Moving all UE/UI bugs to new component: User Interface: Design Feedback
UE/UI component will be deleted.
Component: UE/UI → User Interface: Design Feedback

Updated

19 years ago
Component: User Interface: Design Feedback → XPApps

Comment 8

18 years ago
Move to M20 target milestone.
Target Milestone: M19 → M20

Comment 9

18 years ago
Oops.  Should be M21.
Target Milestone: M20 → M21
Since Don has left, Vishy is taking his bugs in bulk, pending reassignment.
thanks,
	Vishy
Assignee: don → vishy

Updated

18 years ago
QA Contact: elig → sairuh

Comment 11

18 years ago
nav triage team:

Nice to have, but won't hold beta1 for it, marking nsbeta1-
Keywords: nsbeta1-

Updated

18 years ago
Blocks: 66836

Comment 12

17 years ago
Marking nsbeta1- bugs as future to get off the radar.
Target Milestone: --- → Future
(Reporter)

Comment 13

17 years ago
found it at:
http://lxr.mozilla.org/seamonkey/source/xpfe/components/filepicker/res/locale/en
-US/filepicker.properties

normal window programs include the filespec (ala *.html) in the title.

Comment 14

17 years ago
-> law?
Assignee: vishy → law
Target Milestone: Future → ---

Updated

17 years ago
Target Milestone: --- → Future

Comment 15

16 years ago
Actually, this change should effect all the file filters.

For example, on the open file dialog, the filter for HTML files should actually
say something more like "HTML Files (*.html, *.htm)" obviously reflecting the
actual filter. This is just a good habit and prevents confusion, especially in
environments where the extension is still present but hidden from the user anyway.

I personally think because of this this bug deserves a bit more attention than
it's got right now.
Summary: "All Files" should be "All Files (*.*)" → File format filter should be shown to user ("All Files (*.*)")

Comment 16

16 years ago
In addition to comment #13, I beleive the other part of this is at
http://lxr.mozilla.org/seamonkey/source/widget/src/windows/nsFilePicker.cpp#746
Created attachment 128102 [details] [diff] [review]
Adds extenstions to the titles of the filters

This patch adds the extensions to the filter titles in the dropdown of Open
File. 

note: I have not been able to test this on a mac, someone plz. verify that.

Updated

15 years ago
Keywords: qawanted
Comment on attachment 128102 [details] [diff] [review]
Adds extenstions to the titles of the filters

timeless: I added you since you reviewed the last version.
Attachment #128102 - Flags: review?(timeless)

Comment 19

15 years ago
Comment on attachment 128102 [details] [diff] [review]
Adds extenstions to the titles of the filters

get an xpfe owner to sign off
Attachment #128102 - Flags: review?(timeless) → superreview?(jaggernaut)

Updated

15 years ago
Attachment #128102 - Flags: review?(jaggernaut)
(Assignee)

Comment 20

15 years ago
Comment on attachment 128102 [details] [diff] [review]
Adds extenstions to the titles of the filters

Instead of duplicating this text, could you change the xxxTitle to be "xxx
Files (%S)" and then from the js substitute the xxxFilter? E.g.
bundle.getFormattedString("xxxTitle", [ bundle.getString("xxxFilter") ]);

That'll save you on duplication and maintenance (see xulTitle in your patch as
a good example of why).
Attachment #128102 - Flags: superreview?(jaggernaut)
Attachment #128102 - Flags: review?(jaggernaut)
Attachment #128102 - Flags: review-
Thanx for the commment, I'll try and do it this weekend.

Comment 22

14 years ago
If no one is still working on this, I'd be glad to take this over... however,
jag, if you're reading, I have a question about your suggestions in your last
comments.

Thanks.

Comment 23

14 years ago
Note that the linux filepicker already combines the filter into the label.

Comment 24

14 years ago
Comment on attachment 128102 [details] [diff] [review]
Adds extenstions to the titles of the filters

jag's comments don't make sense.

we have:

text(Filter|Title), Text Files, *.txt; *.text.
Attachment #128102 - Flags: review- → review?(neil.parkwaycc.co.uk)

Comment 25

14 years ago
Comment on attachment 128102 [details] [diff] [review]
Adds extenstions to the titles of the filters

oh blah. it makes sense, it's just a bad idea.

actually, all of this code is bad.

for one there's a perf penalty.
for another, it forces behaviors which will annoy translators and others.

what bothers me the most is that the api doesn't offer mime types.

on beos i want:

HTML Files (text/html) [but really, the text/html doesn't need to be listed in
the file type list, it's just what would be listed]

not

HTML Files (*.htm; *.html).

Note that BBEdit (Lite) has:

Enable [All Available	|v]
	Any File
	-
	Text Files
	PICT Files
	QuickTime Movies
	QuickTime Images

So this probably really should be a toolkit decission and not a localizer one.
(Assignee)

Comment 26

14 years ago
> for one there's a perf penalty.

Yeah, sure. A significant perf penalty though? I doubt it. Worth not having to
duplicate the filter? I think so.

> for another, it forces behaviors which will annoy translators and others.

How so? By using formatString they can place the "filter" wherever they want it
in the title, or even leave it out.

The MIME type thing is a separate bug.

Neil: thanks for pointing out that linux already does this.

http://lxr.mozilla.org/mozilla/source/xpfe/components/filepicker/res/content/filepicker.js#116

This code is currently hardcoding the "( *.html; ... )" part which is l10n
unfriendly. Once we have the generic solution this code should be updated to use
that.

It looks like we'd only have to put the formatString code in both the
|appendFilters| (plural) implementations, right?

Comment 27

14 years ago
Comment on attachment 128102 [details] [diff] [review]
Adds extenstions to the titles of the filters

This is Mac-unfriendly.
Attachment #128102 - Flags: review?(neil.parkwaycc.co.uk) → review-
Product: Core → Mozilla Application Suite

Updated

13 years ago
Keywords: qawanted

Comment 28

11 years ago
i'm trying to get help. but no administrator is here. my brand new home machine has the same exact stuff and i've had it for years. i've reported to police umteen times and the fbi. alot of trouble but no help. thx jbt23@nau.edu

thank you all for your efforts, i know that since this is not my machine but at the university i can't get too much help. any ideas? pls let me know at jbt23@nau.edu
Assignee: law → jag
Priority: P3 → --
QA Contact: bugzilla
Target Milestone: Future → ---
You need to log in before you can comment on or make changes to this bug.