InternetSearchDataSource::ReadFileContents use of PRInt64 is broken

RESOLVED EXPIRED

Status

SeaMonkey
Search
RESOLVED EXPIRED
14 years ago
8 years ago

People

(Reporter: timeless, Unassigned)

Tracking

({64bit})

Trunk
x86
Windows XP
64bit
Bug Flags:
blocking1.8a1 -

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

14 years ago
r:/mozilla\xpfe\components\search\src\nsInternetSearchService.cpp(4348) :
warning C4244: 'initializing' : conversion from 'PRInt64' to 'unsigned int',
possible loss of data
r:/mozilla\xpfe\components\search\src\nsInternetSearchService.cpp(4371) :
warning C4244: 'argument' : conversion from 'PRInt64' to 'PRInt32', possible
loss of data

Comment 1

14 years ago
Is anyone actually using the code?  This seems pretty bad as the truncated value
is used to allocate a buffer and the real value is used as its size.
Actually, any place where this would be an issue we would have bigger problems
-- like trying to allocate a 4GB+ array.

This code should really just read the file say 4k at a time and stick it into
its string.....

Or better yet, stop trying to stuff it in a string.

Updated

14 years ago
Flags: blocking1.8a?

Updated

14 years ago
Flags: blocking1.8a? → blocking1.8a-
Product: Core → SeaMonkey

Comment 3

9 years ago
MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614
Status: NEW → UNCONFIRMED

Comment 4

8 years ago
MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420
Status: UNCONFIRMED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → EXPIRED
You need to log in before you can comment on or make changes to this bug.