234943 - Interdiff title doesn't wrap

Status: NEW

(Bugzilla :: Attachments & Requests, defect)

Description

[[e-mail]]

Steps to reproduce problem:
1. Change screen resolution to less than 1600x1200
2. Load the provided interdiff url
3. Scroll horizontally...

Comment 1

[Christian Reis]

Attachment: kiko_v1: neil asks, I do.

The proper fix to this problem is to stop using tables in the page headings.
Unfortunately, that's not exactly trivial to do -- it has high impact over the
page layout. Give that the heading is rendered in an <h1>, I find having the
full summary of both attachments a bit excessive. I've changed them to be
displayed as link titles.

I've also done some serious improvement of the header to make it lay out in
different window sizes and fixing a bug in which header=0 mode laid things out
horribly.

I've also changed the template to use FILTER bug_link as well so we get link
titles for bugs. All in all, a well-spent 30m of work.

Comment 2

[[e-mail]]

(In reply to comment #1)
>The proper fix to this problem is to stop using tables in the page headings.
I don't have a problem against tables, but why use nowrap?

Comment 3

[Christian Reis]

I don't understand it either. It comes from the old days and survived the CSS
migration in bug 278125.

Do you not find the heading for interdiff too long anyway, or would you prefer
not having the attachment descriptions in an <a title="">? I can adapt easily
either way, but nowrap will need to be removed in another bug. 

Comment 4

[[e-mail]]

Don't worry, titles will be fine.

Comment 5

[Frédéric Buclin]

Comment on attachment 187840 [details] [diff] [review]
kiko_v1: neil asks, I do.

>+    for [% terms.bug _ "#" _ bugid FILTER bug_link(bugid) %]

Nit: missing whitespace before '#'.


>-[% IF attachid %]
>-  [% IF headers %]
      ...
>-  [% END %]
>-[% ELSE %]
>-  [% IF headers %]
      ...
>-  [% END %]
>-[% END %]

>+  [% IF attachid && headers %]
      ...
>+  [% ELSE %]
      ...
>+  [% END %]

Note that you completely changed the logic here. Go to the "Edit Attachment"
page, click "View attachment as diff", then "Raw unified" at the top of this
frame -> you get an error, because oldid and newid aren't defined. Previously,
you would remain in the first IF block, but due to your change, i.e. adding '&&
headers', you fall into the second block where an interdiff is assumed.

Comment 6

[[e-mail]]

In the meantime I'm using this userContent.css to work around the problem:
  #titles #title,
  #footer .label,
  ul.link li,
  .bz_attach_flags,
  .bz_attach_footer {
    white-space: normal !important;
  }
  #titles #subtitle {
    width: auto !important;
  }