SVG GDIPlus String bustage

VERIFIED FIXED

Status

()

Core
SVG
VERIFIED FIXED
14 years ago
13 years ago

People

(Reporter: bc, Assigned: bc)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

v1
1.17 KB, patch
Alex Fritze
: review+
Details | Diff | Splinter Review
(Assignee)

Description

14 years ago
With Darin's string landing this busted. 

mozilla/layout/svg/renderer/src/gdiplus/nsSVGGDIPlusGlyphMetrics.cpp(509) 
: error C2665: 'ToLowerCase'
: none of the 3 overloads can convert parameter 1 from type 'class nsAutoString'
(Assignee)

Comment 1

14 years ago
Created attachment 141779 [details] [diff] [review]
patch v0

Darin and Boris helped with the patch but are not responsible for any errors.
you shouldn't need the LOCAL_INCLUDES change, I would think.....
(Assignee)

Comment 3

14 years ago
I tried it with just the change to the REQUIRES, but it couldn't find the
header. I don't know if this is the right way to fix it, but it built. ;-)
Oh, hmm... what if you use "unicharutil" instead of "impl" in REQUIRES?  It
looks like those are separate modules..
(Assignee)

Comment 6

14 years ago
Created attachment 141782 [details] [diff] [review]
v1

patch v1 add unicharutil to REQUIRES instead of intl and don't mess with
LOCAL_INCLUDES builds depends fine for me.
Attachment #141779 - Attachment is obsolete: true
Comment on attachment 141782 [details] [diff] [review]
v1

sr=bzbarsky.  ;)
Attachment #141782 - Flags: superreview+
Attachment #141782 - Flags: review?(alex)

Comment 8

14 years ago
r=darin if that helps.

Updated

14 years ago
Attachment #141782 - Flags: review?(alex) → review+
Assignee: alex → bc
I've gone ahead and checked that patch in.  Thanks for doing this, bc!
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
(Assignee)

Comment 10

14 years ago
verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.