With Darin's string landing this busted. mozilla/layout/svg/renderer/src/gdiplus/nsSVGGDIPlusGlyphMetrics.cpp(509) : error C2665: 'ToLowerCase' : none of the 3 overloads can convert parameter 1 from type 'class nsAutoString'
Created attachment 141779 [details] [diff] [review] patch v0 Darin and Boris helped with the patch but are not responsible for any errors.
you shouldn't need the LOCAL_INCLUDES change, I would think.....
I tried it with just the change to the REQUIRES, but it couldn't find the header. I don't know if this is the right way to fix it, but it built. ;-)
Oh, hmm... what if you use "unicharutil" instead of "impl" in REQUIRES? It looks like those are separate modules..
er, instead of "intl"
Created attachment 141782 [details] [diff] [review] v1 patch v1 add unicharutil to REQUIRES instead of intl and don't mess with LOCAL_INCLUDES builds depends fine for me.
Attachment #141779 - Attachment is obsolete: true
Comment on attachment 141782 [details] [diff] [review] v1 sr=bzbarsky. ;)
r=darin if that helps.
14 years ago
Assignee: alex → bc
I've gone ahead and checked that patch in. Thanks for doing this, bc!
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.