23498 - [FEATURE] Need to be able to programmatically focus XUL elements (like trees and titledbuttons)

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Eric Plaster]

Can't focus a tree without clicking the mouse in it's content.  This happens in
mail as well as address book.  When you bring up these windows (as well as the
one that I am writing) it would be nice to be able to focus the tree in the
OnLoad function so that the tree got events (like up and down arrow keys).

Comment 1

[David Hyatt]

Wanna look at this one for me, waterson?

All I had to do was add focus/blur to the XULElement IDL (and to those DOM props 
files).  Then the only other change was to XUL element.  The methods are 
included below.

NS_IMETHODIMP
nsXULElement::Focus()
{
  // Make sure we're focusable.
  nsCOMPtr<nsIFocusableContent> focusable = 
do_QueryInterface((nsIStyledContent*)this);
  if (!focusable)
    return NS_OK;

  // Obtain a presentation context and then call SetFocus.
  PRInt32 count = mDocument->GetNumberOfShells();
  if (count == 0)
    return NS_OK;

  nsCOMPtr<nsIPresShell> shell = getter_AddRefs(mDocument->GetShellAt(0));
  
  // Retrieve the context
  nsCOMPtr<nsIPresContext> aPresContext;
  shell->GetPresContext(getter_AddRefs(aPresContext));

  // Set focus
  return SetFocus(aPresContext);
}

NS_IMETHODIMP
nsXULElement::Blur()
{
  // Make sure we're focusable.
  nsCOMPtr<nsIFocusableContent> focusable = 
do_QueryInterface((nsIStyledContent*)this);
  if (!focusable)
    return NS_OK;

  // Obtain a presentation context and then call SetFocus.
  PRInt32 count = mDocument->GetNumberOfShells();
  if (count == 0)
    return NS_OK;

  nsCOMPtr<nsIPresShell> shell = getter_AddRefs(mDocument->GetShellAt(0));
  
  // Retrieve the context
  nsCOMPtr<nsIPresContext> aPresContext;
  shell->GetPresContext(getter_AddRefs(aPresContext));

  // Set focus
  return RemoveFocus(aPresContext);
}

Comment 2

[David Hyatt]

Fixed.

Comment 3

[Paul MacQuiddy]

please ignore, massive spam giving [e-mail] backlog of XPToolkits
resolved fixed bugs to verify

Comment 4

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/3b77779694e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23498 add content description for wallpapers
https://hg.mozilla.org/releases/mozilla-beta/rev/6465e030a8b8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23498 improve logo content description comments for wallpapers