235062 - onClick event not being handled before form submit

Status: RESOLVED WORKSFORME

(Core :: DOM: Events, defect)

Description

[Matt Cosentino]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

When I have a submit button with an onClick event handler, the form is submitted
before the event is handled.  In all previous versions of the browser, as well
as in IE, the event is handled first and then the form is submitted.  I can see
this possibly causing major problems on many previously working sites.

Reproducible: Always
Steps to Reproduce:
1. Click on submit button with onClick event handler

Actual Results:  
Form is submitted and the event is handled afterwards.

Expected Results:  
The event should be handled first before the form is submitted.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

That testcase worksforme with a current trunk linux build -- the click event is
fired before the submit (as you can tell by the resulting URI).

Does that testcase show the problem for you, Matt?  If not, could you attach one
that does?

Comment 3

[Matt Cosentino]

I tried the test case and got "The attachment id is invalid." and the uri showed
"test=" the first time and "test=clicked" the second time.  This is the same
behavior I experienced on my site.

I have a trunk build installed on my home computer, I'll try it when I get home
and see if I get the same result.

Comment 4

[Matt Cosentino]

Works in my trunk build.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040211
Firebird/0.8.0+ (stipe)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Ok.  Sounds like a 1.6 problem then... (or a firefox 0.8 problem)

Comment 6

[Matt Cosentino]

Just realized this happens for regular links as well as forms.  Sucks that a bug
like this made it into the release.

Comment 7

[Korey Klier]

Went back to problem as described in Summary.  Found that

C:\Documents and Settings\USERNAME\Application
Data\Phoenix\Profiles\default\guhh97z5.slt\signons.txt

was the problem. I deleted the file and restarted FireFox 0.8.  Everything is fine.