[FIX]TEXTAREA narrow than set by COLS= (newlines don't end unquoted attributes)

RESOLVED FIXED in mozilla1.7beta

Status

()

Core
HTML: Parser
P1
normal
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: noririty, Assigned: bz)

Tracking

({qawanted, regression})

Trunk
mozilla1.7beta
qawanted, regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
- Occurs On 20040219
- Doesn't Occur On 20040221
(Reporter)

Comment 1

14 years ago
oops, it was opposite.
- Doesn't Occur On 20040219
- Occurs On 20040221
Keywords: qawanted
What are the times to go with those dates?  What about 2004-02-20-XX?
This is a parser issue (look in DOM inspector and notice that the cols attr
isn't even set).
Assignee: nobody → parser
Component: Layout: Form Controls → HTML: Parser
Created attachment 141974 [details] [diff] [review]
Fix

The idea here is to only allow newlines inside quoted attrs.  Other attrs
should be terminated by newlines.
(Assignee)

Updated

14 years ago
Attachment #141974 - Flags: superreview?(jst)
Attachment #141974 - Flags: review?(choess)
This is a regression from bug 137315 
Assignee: parser → bzbarsky
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Summary: TEXTAREA narrow than set by COLS= → [FIX]TEXTAREA narrow than set by COLS=
Target Milestone: --- → mozilla1.7beta
Comment on attachment 141974 [details] [diff] [review]
Fix

+      else if(aAllowNewlines && ch == kCR) {
...
>+      else if(aAllowNewlines && ch == kNewLine) {

Would it not generally be faster to check ch == k... before checking
aAllowNewlines?

sr=jst
Attachment #141974 - Flags: superreview?(jst) → superreview+
Hmm.. probably.  I will change that before checking in.
(Assignee)

Updated

14 years ago
Summary: [FIX]TEXTAREA narrow than set by COLS= → [FIX]TEXTAREA narrow than set by COLS= (newlines don't end unquoted attributes)
*** Bug 235340 has been marked as a duplicate of this bug. ***
Attachment #141974 - Flags: review?(choess) → review+
Checked in, with that change.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
*** Bug 235497 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.