235269 - Standalone builds are broken because build/unix/modules.mk wasn't updated to remove xpcom/string/embed

Status: RESOLVED INCOMPLETE

(Core :: XPCOM, defect)

Description

[timeless]

Standalone builds are broken because modules.mk wasn't updated.

cls doesn't want people to use the quick and dirty fix (i've included it here
for reference...). This is the perl i used to work around the problem:
perl -pi -e 's| xpcom/string/embed||g' mozilla/build/unix/modules.mk

but the correct thing is to use:
mozilla/tools/modules-deps

fwiw
$ cat $MOZCONFIG
# sh
# Build configuration script
#
# See http://www.mozilla.org/build/unix.html for build instructions.
#

# Options for client.mk.
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/debug-xpconnect-@CONFIG_GUESS@
mk_add_options CFLAGS=-xs
mk_add_options CXXFLAGS=-xs
mk_add_options LDFLAGS=-xs
mk_add_options ARFLAGS=-xs

# Options for 'configure' (same as command-line options).
#ac_add_options --enable-calendar
ac_add_options --enable-crypto
#ac_add_options --enable-ctl
ac_add_options --disable-accessibility
ac_add_options --disable-activex
#ac_add_options --enable-extensions=all
#ac_add_options --enable-ldap-experimental
ac_add_options --disable-ldap
ac_add_options --enable-xpctools
ac_add_options --enable-logrefcnt
ac_add_options --enable-detect-webshell-leaks
ac_add_options --enable-timeline
ac_add_options --enable-reflow-perf
ac_add_options --enable-perf-metrics
#ac_add_options --enable-codesighs
ac_add_options --enable-trace-malloc
ac_add_options --enable-standalone-modules=xpconnect
ac_add_options --disable-gtktest
ac_add_options --disable-toolkit-gtk
ac_add_options --enable-default-toolkit=xlib

Comment 1

[Benjamin Smedberg]

The standalone build is gone.