15.56 KB, image/png
441 bytes, patch
|Details | Diff | Splinter Review|
1.37 KB, patch
|Details | Diff | Splinter Review|
User-Agent: Build Identifier: there is no icon for the personal bookmark toolbar items when in the customize palette. there is no indication that the bookmarks flex to fill the toolbar. Reproducible: Always Steps to Reproduce: 1. enter toolbar customize mode 2. drag bookmarks into palette Actual Results: all you see is "Bookmarks" with no icon Expected Results: an icon or some better visual representation of what the item is
Created attachment 142036 [details] image illustrating bug, and potential remedies 1. current broken state in palette. no icon. same label as bookmarks sidebar button. 2. fixed existing code. same label as bookmarks sidebar button. not apparent that this is the personal bookmarks toolbar item. 3. restyled to use more descriptive label, with appearance more suggestive of functionality. 4. current state on toolbar during customize. no indication of space taken by the whole item. 5. how it would look restyled using same fix as "3" with borders showing size of object similar to a flexible space.
Created attachment 142038 [details] [diff] [review] patch fixing existing code to show icon in palette the code for the bookmark toolbar was already in classic/skin/classic/browser/browser.css, it was just slighty incorrect. this one line patch corrects it as shown in "2" in the image in comment #1.
Created attachment 142040 [details] [diff] [review] patch restyling bookmarks toolbar items this patch makes the changes as shown in "3" and "5" in the image attached to comment #1. it uses the same, more descriptive label in the palette as used on the toolbar. the standard "Bookmarks" palette item label is removed. borders are also added to illustrate the size of the bookmarks while on the toolbar. i would recommend this patch be used. - uses better label - item appears similar both in palette and on toolbar - eliminates potential confusion caused by this having the same label as the bookmark sidebar button - true size of item on toolbar is apparent with borders, which will help when positioning items and should help prevent items from being "lost" when added after the bookmarks
Comment on attachment 142038 [details] [diff] [review] patch fixing existing code to show icon in palette Blake, do you like that approach?
Comment on attachment 142040 [details] [diff] [review] patch restyling bookmarks toolbar items Blake, do you like that approach?
Confirming. Assigning to miahz.
Comment on attachment 142040 [details] [diff] [review] patch restyling bookmarks toolbar items lets go ahead a file a separate bug about the styling against email@example.com
Comment on attachment 142038 [details] [diff] [review] patch fixing existing code to show icon in palette as noted, the styling should go to arvid for decisions, but in the absence of that, lets get this in so we're not broken
checked in branch and trunk, thanks for the patch! Please file a followup bug for Arvid to look at the styling here.
resolving FIXED, please note the followup bug here if/when filed.
thanks, mike. something must be up with myrealbox email, cuz i haven't gotten any mail in a couple days - i read about this checkin in the nightly build forum thread. i'll whip up the new bug as soon as i can.
It's broken again. I just looked at it, and the fix is the exact same thing as last time, though the patch might be off by a line or so. How did the theme get back-graded to where this was unfixed? Needs to be reopened (i don't think i'm strong enough to change it). And now maybe the alternate second patch can be reconsidered. Actually, just checked, and the bookmark folder icon image (chrome://browser/skin/Bookmarks-folder.png) isn't in the theme anymore. (Yet another reason to go with the second approach - it uses the normal bookmark icon.) But that doesn't explain why the code backed up.
*** Bug 206159 has been marked as a duplicate of this bug. ***
I can reproduce this bug in my system Windows XP. Here is my configuration: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3
This (along with a few other bugs) was tagged as fixed-aviary1.0, but is not truly fixed. browser/Bookmarks-folder.png was checked in, but it is corrupt or something - it does not display and will not open in any image viewer/editor i tried. Still broken. 17th/Windows 2000 [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041017 Firefox/1.0]
The icon is displayed just fine here: http://lxr.mozilla.org/seamonkey/source/browser/themes/winstripe/browser/Bookmarks-folder.png http://lxr.mozilla.org/seamonkey/source/browser/themes/pinstripe/browser/bookmarks/bookmark-folder.png Marking fixed again.