23546 - nsPluginsDir::nsPluginsDir()

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Bruce Mitchener]

const char* allocPath;

allocPath = PL_strdup(pluginsDir);
*(nsFileSpec*)this = allocPath;

This leaks the allocPath.  I reported this for Windows and the PL_strdup() was
removed.  This should be done here as well (just do: *(nsFileSpec*)this =
pluginsDir; and get rid of allocPath altogether).  Would be good to look at Mac
and other platforms as well probably.

Comment 1

[Bruce Mitchener]

Does [e-mail] still work there?  This is a _very_ easy fix and hasn't
been touched in over a month.

Comment 2

[av (gone)]

I do. And I will look at this and other issue as soon as I finish my PDT+ bugs.

Comment 3

[Bruce Mitchener]

I'll be happy to take this on, test the fix under Purify, and get it approved 
and checked in then.  Assign it over to me if you like.

Comment 4

[av (gone)]

Thanks! Gladly doing so. Any other help especially with Unix and Mac would be 
greately appreciated.

Comment 5

[Bruce Mitchener]

Attachment: Fixes leak.

Comment 6

[Bruce Mitchener]

Doug, please review this ... I tested it under Purify and it works fine. Thanks!

Comment 7

[Doug Turner (:dougt)]

looks good.

Comment 8

[Bruce Mitchener]

And fix checked in.

Comment 9

[Scott Collins]

If you have to cast, a |NS_STATIC_CAST| would be better.  However, the result 
(and hence, your meaning) might be made clearer by saying

  this->nsFileSpec::operator=(pluginsDir);

Comment 10

[Bruce Mitchener]

this was fixed.

Comment 11

[rusty.lynch]

It looks like my legacy plugin check-in way back when did an override of Bruces 
fix.  Can I get the OK to fix this by getting rid of the strdup?

Comment 12

[rusty.lynch]

yea, forgot the cc

Comment 13

[Brendan Eich [:brendan]]

a=[e-mail] for rusty.

/be

Comment 14

[rusty.lynch]

fixed rechecked in.

Comment 15

[shrirang khanzode]

verified that the fix is in the tree.