Closed Bug 235472 Opened 21 years ago Closed 21 years ago

Make the filter dialog size in proportion to the font size

Categories

(MailNews Core :: Filters, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.7beta

People

(Reporter: mscott, Assigned: Stefan.Borggraefe)

References

Details

Attachments

(2 files, 2 obsolete files)

http://bugzilla.mozilla.org/show_bug.cgi?id=233028#c10

Thanks for looking into this Stefan!
Severity: normal → trivial
Status: NEW → ASSIGNED
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → mozilla1.7beta
Attached patch Patch (obsolete) — Splinter Review
The FilterListDialog also has a default size that is not proportional to the
used font size. This patch fixes both dialogs.
Attachment #142215 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 142215 [details] [diff] [review]
Patch

Could you reduce those sizes slightly, e.g. 48em to 45em?
Attached patch Patch V1.1 (obsolete) — Splinter Review
Ok, I reduced the sizes a little bit. This should still fit.

FYI: The configuration which needed the most space in my tests was Classic
mozilla-theme on a Linux gtk1 build with the Geramik gtk-theme. This
configuration needed even more space than using Classic with Windows XP.
Attachment #142215 - Attachment is obsolete: true
Attachment #142215 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #142337 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 142337 [details] [diff] [review]
Patch V1.1

I've just twigged that the old width= height= dimensions apply to the outer
dimensions, but the styled dimensions apply to the inner dimensions; this
doesn't matter much for the width but the window still looks too tall because
of the title bar. Please could you shorten both windows another couple of em?
*** Bug 235699 has been marked as a duplicate of this bug. ***
Attached patch Patch V1.2Splinter Review
Reduced height of both windows by 3em.
Attachment #142337 - Attachment is obsolete: true
Attachment #142337 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #142352 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 142352 [details] [diff] [review]
Patch V1.2

Goldilocks and the Three Patches... this one's Just Right ;-)
Attachment #142352 - Flags: review?(neil.parkwaycc.co.uk) → review+
Comment on attachment 142352 [details] [diff] [review]
Patch V1.2

lol...thanks a lot guys
Attachment #142352 - Flags: superreview+
Scott: Could you check this in (and perhaps the patch for bug 223295, too)?
Thanks! :-)

After some web-searching I now know about Goldilocks, too. She's unknown in
Germany or at least to me. So at least I learned something new by doing *three*
patches for this bug. ;-)
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: