23573 - the all-ns.js overrides not working on windows.

Status: VERIFIED FIXED

(Core :: Preferences: Backend, defect, P1)

Description

[(not reading, please use [e-mail] instead)]

valeski pointed out that all-ns.js, while in the right place in his debug tree,
is not overriding the prefs in all.js

I have a guess at why this might be the case, and I'll look into fixing this
problem tomorrow.

my guess is the directory iterators for the different platforms return the files
in a different order.

if I can't rely on that that, I'm going to fix it so given a flag to the
directory iterator, you will get things back in a way friendly to the
<vendor>-<preffilename> trick.

Comment 1

[(not reading, please use [e-mail] instead)]

possibly related to bug #22931

Comment 2

[(not reading, please use [e-mail] instead)]

whoops, that was <preffilename>-<vendor>.js

like mailnews-ns.js

I was relying on the results being alphabetical.

Comment 3

[(not reading, please use [e-mail] instead)]

marking m13, p1.

Comment 4

[(not reading, please use [e-mail] instead)]

fixed.

the fix is to sort the files in reverse alphabetical order before parsing them.

this works, because "all." is after "all-".  therefore, we parse "all.js" before
"all-ns.js"

valeski, now that this and the windows packaging bug #22931 are fixed, you
should be able to test and mark #23211 fixed

Comment 5

[sairuh (rarely reading bugmail)]

verif.

Comment 6

[leger]

Moving all libPref component bugs to new Preferences: Backend component.  
libPref component will be deleted.