235759 - Mozilla v1.7a/Windows: the *.jar files in the chrome directory have Unix line endings. [v1.8a1-v18a2 too, other sub-directories too.]

Status: RESOLVED WONTFIX

(SeaMonkey :: Build Config, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7a) Gecko/20040219] (W98SE)

"All" the files contained in the *.jar files and <installed-chrome.txt> are
affected :-(

It saves a little space...
But it's painful when one wants to use these files to test and make "UI" patches !

It's a regression:


[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6) Gecko/20040113] (W98SE)

The files have Windows line endings :-)

(and I'm pretty sure v1.6b at least was correct too.)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Note that any reasonable text editor will deal with the Unix line endings.  I
recommend Emacs for Win32 myself.

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> Note that any reasonable text editor will deal with the Unix line endings.

I know (WordPad, CEdit, ... do), still:
Notepad (default editor) does not;
Windiff (Microsoft diff utility) does not, in the way that diffing files from
v1.6 (or retrieved from CVS) and v1.7a "fails"; (That's "how" I noticed this bug)
why would we keep this 'regression', unless this bug is marked WONTFIX with a
reasonnable explanation.

I mean no argument: my point is only that for people with a 'entry-level' setup
like mine, fixing this bug does help to get/stay involved with Mozilla/BugZilla :-|

Comment 3

[Benjamin Smedberg]

Leaf, is this yours?  I must admit I don't understand how chrome could have had
win-style line endings ever; for the most part, all we do is copy the files
around and then zip them up.

Comment 4

[Asa Dotzler [:asa]]

no end-user impact, not a 1.7 blocker.

Comment 5

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7b) Gecko/20040316] (W98SE)

Same bug as Mv1.7a.


[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7b) Gecko/20040421] (<-- 1.7rc1 !)
(W98SE)

Regression fixed.


Some files, like chrome.rdf and installed-chrome.txt,
but not chromelist.txt,
still have Unix end of lines:
these have allways been like this, if I remember well.

Still, this should be fixed too !

Comment 6

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7) Gecko/20040616] (W98SE)

v1.7rc1/(v1.7rc2/v1.7rc3)/v1.7: as expected :-)

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a1) Gecko/20040520] (W98SE)

v1.8a1: buggy "again" :-(


This looks like the v1.7 _branch_ builds are fine;
while the _Trunk_ remains wrong.

Leaf (or Benjamin):
Could there be some (Windows build) "settings" to land from the branch build
setup to the Trunk one ?

Comment 7

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a1) Gecko/20040520] (W98SE)

This bug affects the <components\*.js> files too;
and <res\EditorOverride.css>, and "all" the files in <res\samples\*>;
and in <plugins\>, dmoz.src and google.src; but not(!) jeeves.src.

Could it be something like using CygWin with a setting of line ending = CR
instead of CR/LF on the Trunk environment ??

Comment 8

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a2) Gecko/20040714] (release) (W98SE)

Unix eol :-(

Comment 9

[Serge Gautherie (:sgautherie)]

*****

(Long time since I looked into this.)

*(OS) W98 -> W2K, as I upgraded in the meantime.

*****

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/20070428 SeaMonkey/1.5a] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/2007042901 SeaMonkey/1.5a] (suiterunner, tinderbox-builds) (W2Ksp4)

<README.txt> has LF instead of CR/LF,
which seems inappropriate for this user-oriented file.

Comment 10

[Philip Chee]

Serge, can this bug be closed?

Comment 11

[Robert Kaiser]

I think this should be WONTFIX, we're all unix LF nowadays and no intention of changing it.

Comment 12

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b3pre) Gecko/20081216 SeaMonkey/2.0a3pre] (nightly) (W2Ksp4)

license.txt and readme.txt have CR+LF :-)
All the others seem to have CR only :-|

R.WontFix, per previous comment(s)...