In <FilterListDialog.js>, "Warning: redeclaration of var item"

RESOLVED FIXED in mozilla1.7beta

Status

MailNews Core
Filters
--
minor
RESOLVED FIXED
14 years ago
10 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

Trunk
mozilla1.7beta

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 obsolete attachments)

(Assignee)

Description

14 years ago
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7a) Gecko/20040219] (W98SE)

{
Warning: redeclaration of var item
Source File: chrome://messenger/content/FilterListDialog.js
Line: 159, Column: 8
Source Code:
    var item = event.target;
}

Testcase:
1. MailNews > Tools > Message Filters...
(Assignee)

Updated

14 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

14 years ago
Created attachment 142598 [details] [diff] [review]
(Av1) <FilterListDialog.js>
(Assignee)

Updated

14 years ago
Attachment #142598 - Flags: review?(neil.parkwaycc.co.uk)
(Assignee)

Updated

14 years ago
Attachment #142598 - Attachment is obsolete: true
Attachment #142598 - Flags: review?(neil.parkwaycc.co.uk)
(Assignee)

Comment 2

14 years ago
Created attachment 142602 [details] [diff] [review]
(Av1b) <FilterListDialog.js>

Av1, totally revised.
(Assignee)

Updated

14 years ago
Attachment #142602 - Flags: review?(neil.parkwaycc.co.uk)

Comment 3

14 years ago
Comment on attachment 142602 [details] [diff] [review]
(Av1b) <FilterListDialog.js>

>diff -u -p -r1.52 FilterListDialog.js
This patch seems to change the indentation of some lines but not others... if
you meant to change the indentation, then you should provide two patches, one
showing the new indentation and one with the extra -w option to diff showing
only the changes that are not indentation.

>+  var itemId = event.target.id;
It might be an idea to use a slightly more meaningful variable name e.g.
itemURI
Attachment #142602 - Flags: review?(neil.parkwaycc.co.uk) → review+
(Assignee)

Updated

14 years ago
Attachment #142602 - Attachment is obsolete: true
(Assignee)

Comment 4

14 years ago
Created attachment 143182 [details] [diff] [review]
(Av2) <FilterListDialog.js>
[Checked in: Comment 7]

Av1b, with comment 3 suggestion(s).
(Assignee)

Comment 5

14 years ago
Comment on attachment 143182 [details] [diff] [review]
(Av2) <FilterListDialog.js>
[Checked in: Comment 7]


Keeping { (Av1b) <FilterListDialog.js>		 patch		2004-02-29
08:03 PST    neil.parkwaycc.co.uk: review+ }
Attachment #143182 - Flags: superreview?(mscott)
Attachment #143182 - Flags: review+

Updated

14 years ago
Attachment #143182 - Flags: superreview?(mscott) → superreview+
(Assignee)

Updated

14 years ago
Attachment #143182 - Flags: approval1.7b?

Comment 6

14 years ago
Comment on attachment 143182 [details] [diff] [review]
(Av2) <FilterListDialog.js>
[Checked in: Comment 7]

a=chofmann for 1.7b
Attachment #143182 - Flags: approval1.7b? → approval1.7b+

Comment 7

14 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
(Assignee)

Updated

14 years ago
Attachment #143182 - Attachment description: (Av2) <FilterListDialog.js> → (Av2) <FilterListDialog.js> [Checked in: Comment 7]
Attachment #143182 - Attachment is obsolete: true
(Assignee)

Updated

14 years ago
Target Milestone: --- → mozilla1.7beta
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.