236155 - Chatzilla should use contract ID, not class ID

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Nick Sayer]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113

extensions/irc/js/lib/connection-xpcom.js has this:

var sockServiceClass =
        Components.classesByID["{c07e81e0-ef12-11d2-92b6-00105a1b0d64}"];

It should probably say

var sockServiceClass =
        Components.classes["@mozilla.org/network/socket-transport-service;1"];

Reproducible: Always
Steps to Reproduce:

Comment 1

[James Ross]

Attachment: Use contract ID

Comment 2

[Robert Ginda]

Comment on attachment 171062 [details] [diff] [review]
Use contract ID

could be that at the time this was written, the socket transport service didn't
have a class id.  you might want to check an early mozilla to be sure. 
otherwise, r=rginda

Comment 3

[James Ross]

Seems it doesn't exist prior to
  nsNetCID.h: 1.24 <[e-mail]> 2003-01-17 18:14

Mozilla 1.0 branched on 2002-04-09. :)

*goes to do another patch*

Comment 4

[James Ross]

Comment on attachment 171062 [details] [diff] [review]
Use contract ID

Minusing so no-one gets confused. This patch wont work in Mozilla 1.0.

Comment 5

[James Ross]

Attachment: Take two - this time with both contract ID and CID

I have yet to test this at all, but I will try in both trunk Mozilla and 1.0
before checking it in.

The comment is just a reminder that the CID should never be updated, since it
is for Mozilla during the 2002 - 2003 period only.

Comment 6

[Robert Ginda]

Comment on attachment 171945 [details] [diff] [review]
Take two - this time with both contract ID and CID

this might throw a strict warning.  if so, an "in" test would be a better idea.

Comment 7

[James Ross]

I could not get it to produce a warning on 1.0 or 1.7.1.

Comment 8

[James Ross]

*poke*

rginda, any chance of that review? ;)

Comment 9

[Robert Ginda]

Comment on attachment 171945 [details] [diff] [review]
Take two - this time with both contract ID and CID

This would save a vew bytes of source test :)

var sockServiceClass = (sockClassByName || sockClassByID);

r=rginda either way

Comment 10

[James Ross]

Checked in -> FIXED.