Status

RESOLVED FIXED
15 years ago
14 years ago

People

(Reporter: bugzilla-mozilla-20000923, Assigned: rginda)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: cz-patch)

Attachments

(3 obsolete attachments)

(Reporter)

Description

15 years ago
I've got a patch here, that fixes server passwords so they work each time, shows
half-ops in the channel header box, and makes notice messages work when all the
nicknames are off-line.
(Reporter)

Comment 1

15 years ago
Created attachment 142720 [details] [diff] [review]
Fixes server passwords, notify messages and shows half-ops.

This also bumps the version up to 0.9.60.
(Reporter)

Updated

15 years ago
Whiteboard: cz-patch
(Reporter)

Comment 2

15 years ago
Created attachment 142723 [details] [diff] [review]
Make delete/hide-view re-select current tab

Makes delete/hide-view work properly when working on a view to the left of the
current view, in particular when current view is the last.

Updated

15 years ago
Attachment #142720 - Flags: review+

Updated

15 years ago
Attachment #142723 - Flags: review+
(Reporter)

Comment 3

15 years ago
Created attachment 142724 [details] [diff] [review]
Munges lines into plain text to stalk matching.

Don't really like doing this, but it does fix the problem that colours
codes/bold, etc. inside stalk words won't match. I can run this extra munger +
regexp replace 45+ times/sec on a reasonably colourful line here (P3 750MHz) so
I think it's ok for now.
(Reporter)

Comment 4

15 years ago
Comment on attachment 142720 [details] [diff] [review]
Fixes server passwords, notify messages and shows half-ops.

Checked in.
Attachment #142720 - Attachment is obsolete: true
(Reporter)

Comment 5

15 years ago
Comment on attachment 142723 [details] [diff] [review]
Make delete/hide-view re-select current tab

Checked in.
Attachment #142723 - Attachment is obsolete: true
(Assignee)

Comment 6

15 years ago
Comment on attachment 142724 [details] [diff] [review]
Munges lines into plain text to stalk matching.

It's really ugly, but I suppose it'll do for a while.  Please add a big comment
explaining why it's there though.
Attachment #142724 - Flags: review+
(Assignee)

Comment 7

15 years ago
Comment on attachment 142724 [details] [diff] [review]
Munges lines into plain text to stalk matching.

this would probably be better off in msgIsImportant(), actually.
(Reporter)

Comment 8

15 years ago
Comment on attachment 142724 [details] [diff] [review]
Munges lines into plain text to stalk matching.

Checked in. Actual diff here:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&s
ubdir=mozilla/extensions/irc/xul/content&command=DIFF_FRAMESET&file=static.js&r
ev1=1.99&rev2=1.100&root=/cvsroot (moved code to msgIsImportant, and added big
comment)
Attachment #142724 - Attachment is obsolete: true
(Reporter)

Comment 9

15 years ago
Marking fixed as all patches have been checked in.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Product: Core → Other Applications
You need to log in before you can comment on or make changes to this bug.