236157 - Misc fixes (0.9.60)

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[James Ross]

I've got a patch here, that fixes server passwords so they work each time, shows
half-ops in the channel header box, and makes notice messages work when all the
nicknames are off-line.

Comment 1

[James Ross]

Attachment: Fixes server passwords, notify messages and shows half-ops.

This also bumps the version up to 0.9.60.

Comment 2

[James Ross]

Attachment: Make delete/hide-view re-select current tab

Makes delete/hide-view work properly when working on a view to the left of the
current view, in particular when current view is the last.

Comment 3

[James Ross]

Attachment: Munges lines into plain text to stalk matching.

Don't really like doing this, but it does fix the problem that colours
codes/bold, etc. inside stalk words won't match. I can run this extra munger +
regexp replace 45+ times/sec on a reasonably colourful line here (P3 750MHz) so
I think it's ok for now.

Comment 4

[James Ross]

Comment on attachment 142720 [details] [diff] [review]
Fixes server passwords, notify messages and shows half-ops.

Checked in.

Comment 5

[James Ross]

Comment on attachment 142723 [details] [diff] [review]
Make delete/hide-view re-select current tab

Checked in.

Comment 6

[Robert Ginda]

Comment on attachment 142724 [details] [diff] [review]
Munges lines into plain text to stalk matching.

It's really ugly, but I suppose it'll do for a while.  Please add a big comment
explaining why it's there though.

Comment 7

[Robert Ginda]

Comment on attachment 142724 [details] [diff] [review]
Munges lines into plain text to stalk matching.

this would probably be better off in msgIsImportant(), actually.

Comment 8

[James Ross]

Comment on attachment 142724 [details] [diff] [review]
Munges lines into plain text to stalk matching.

Checked in. Actual diff here:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&s
ubdir=mozilla/extensions/irc/xul/content&command=DIFF_FRAMESET&file=static.js&r
ev1=1.99&rev2=1.100&root=/cvsroot (moved code to msgIsImportant, and added big
comment)

Comment 9

[James Ross]

Marking fixed as all patches have been checked in.