Closed Bug 236208 Opened 20 years ago Closed 20 years ago

lastPageVisited isn't idn-safe

Categories

(Core Graveyard :: History: Global, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

()

Details

(Keywords: intl)

Attachments

(1 file, 1 obsolete file)

History URLs are stored as UTF-8 but lastPageVisited is declared as a string so
it cannot return UTF-8 data. I suggest it is changed to AUTF8String instead.

Steps to reproduce problem:
1. Configure one of your navigator startup prefs to last page visited
2. Visit the URL
3. Open navigator in such a way as to trigger the pref

Expected results: URL opens

Actual results: Mozilla tries to load http://öko.de/
Attached patch Work in progress (obsolete) — Splinter Review
Assignee: nobody → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
OK, so bug 236138 fixed this for the case of retrieving the browser's idea of
the startup page from the last page visited, so all I need to do now is to fix
access to lastPageVisited from script.
Attached patch Proposed patchSplinter Review
Attachment #142749 - Attachment is obsolete: true
Keywords: intl
OS: Windows 2000 → All
Hardware: PC → All
Attachment #142825 - Flags: superreview?(bryner)
Attachment #142825 - Flags: review?(alecf)
OK, let's try again in UTF-8 ...
Steps to reproduce problem:
1. Configure Mozilla to load the last page visited in a new window
2. Open http://öko.de/
3. Open a new browser window

Actual results: Mozilla tries to load http://öko.de/

Note that the new tab case has slightly different code - it actually duplicates
the current tab, rather than loading the last page visited. And bsmedberg fixed
the navigator startup case in bug 236138.
Comment on attachment 142825 [details] [diff] [review]
Proposed patch

in nsBrowserInstance, use nsCAutoString, not nsCString

other than that, sr=alecf
Attachment #142825 - Flags: review?(alecf) → review+
Attachment #142825 - Flags: superreview?(bryner) → superreview+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: