Closed Bug 236241 Opened 20 years ago Closed 20 years ago

Use Current Page fails when Options is not opened from a browser window

Categories

(Firefox :: Settings UI, defect, P2)

Product:
Firefox
Component:
Settings UI
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox0.9

People

(Reporter: demeulenaere, Assigned: mconnor)

References

Details

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

When going into the options menu from Tools/Download, I select current page, and
nothing happens.  I exit and go into it from Tools/Options, it works fine.

Believe it is because the download window is open, may want to have it go into
the options window with download the only highligted button.

Reproducible: Always
Steps to Reproduce:
1.Tools/Download
2. Select Options
3. Go to General tap, select current page.

Actual Results:  
Nothing happens...

Expected Results:  
Put in the browsers current web page, or when Options is hit that only download
page is the only options that can be set.
Looks like the same cause (but different effect) as Bug 231442 Comment 1.
I'm thinking we should be opening the Options dialog as a child of the Download
window's parent window, that would fix this issue and at least one other. 
Blake, is this feasible/desired?
Status: UNCONFIRMED → NEW
Ever confirmed: true
*** Bug 235880 has been marked as a duplicate of this bug. ***
(In reply to comment #2)
> I'm thinking we should be opening the Options dialog as a child of the Download
> window's parent window, that would fix this issue and at least one other. 

There would still be situations where the DM would have to open Options itself
(e.g. if the DM's opener window were closed). So perhaps in addition to the
suggestion in comment 2, the Options box should disable the "Use Current Page"
button if its top.opener isn't a standard browser window?

yeah, that's true.  Maybe we have to limit the scope of that Options window to 
just the Downloads options?  Is there any other functions that get info from 
the parent window?
(In reply to comment #5)
> yeah, that's true.  Maybe we have to limit the scope of that Options window to 
> just the Downloads options?  Is there any other functions that get info from 
> the parent window?

I couldn't find anything else that accesses the parent.
also affects when opened from XP start menu

patch in 231442 has the fix for this, in that it disables the button since we
don't have a "current page" in the context of the dialog.
Assignee: firefox → mconnor
Depends on: 231442
OS: Windows XP → All
Priority: -- → P2
Hardware: PC → All
Summary: Not able to change Home Page if I go into Options through Tools/Downloads → Use Current Page fails when Options is not opened from a browser window
Target Milestone: --- → Firefox0.9
fix for 231442 checked in, branch and trunk, 2004-04-26 21:25
I assume this bug is considered fixed now or is something else planned?
oops, fixed :)
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
I can reproduce this behavior on my Windows XP with Firefox/0.9.3, too.
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → preferences
You need to log in before you can comment on or make changes to this bug.