Closed Bug 236403 Opened 21 years ago Closed 21 years ago

Clean up nsFontMetricsOS2 array usage

Categories

(Core Graveyard :: GFX: OS/2, defect)

x86
OS/2
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jhpedemonte, Assigned: jhpedemonte)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Switched from nsVoidArray to nsTHashtable. Performance has stayed the same, but the code is cleaner, and there are minor size savings in code size and memory usage.
Attachment #142865 - Flags: review?(mkaply)
Comment on attachment 142865 [details] [diff] [review] patch r=mkaply, sr=blizzard (platform specific code)
Attachment #142865 - Flags: superreview+
Attachment #142865 - Flags: review?(mkaply)
Attachment #142865 - Flags: review+
Attached patch patch v1.1Splinter Review
This patch fixes a few bugs in the old patch: (1) need to compare fonts case insensitive, and (2) need to set the correct codepage for symbol fonts.
Attachment #142865 - Attachment is obsolete: true
Last patch checked in on verbal approval from mkaply. Marking fixed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: