236450 - [FIX] noscript element with display type set is rendered even if javascript is enabled

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Lasse Marøen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040302 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040302 Firefox/0.8

When a noscript element has a display type set, the content is rendered even if
javascript is enabled. Furthermore, markup contained in the noscript element is
displayed as plain text.

Reproducible: Always
Steps to Reproduce:
1. Open testcase
2. See results
3. Turn of javascript in browser
4. Reload page

Actual Results:  
Contents of noscript element is shown when javascript is enabled

Expected Results:  
Noscript content should not be rendered if javascript is enabled.

Will upload testcase shortly. This code exposes the problem:

<script type="text/javascript">
document.write("<p>Javascript works</p>");
</script>
<noscript style="display:block;">
<p>Javascript <strong>does not </strong>work.</p>
</noscript>

Both Opera 7.x and IE6 hides the noscript content.

Comment 1

[Lasse Marøen]

Attachment: Testcase - noscript with display type set

Comment 2

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Make 'display:none' important for <noscript> when script is enabled.

Comment 3

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1 (diff -w, for reviewing purposes only)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 143237 [details] [diff] [review]
Patch rev. 1

There's no need for the display:inline thing, is there?  That's the default
value of display, and now that you've removed the ua.css rule there is no need
for the display:inline...

In other words, just flip the sense of the IsScriptEnabled() check and change
the rule to use none!important instead of inline.

Comment 5

[Mats Palmgren (inactive)]

Attachment: Patch rev. 2

Yes, that's better. (sorry for the delay in dealing with this)

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 170133 [details] [diff] [review]
Patch rev. 2

r+sr=bzbarsky

Comment 7

[Mats Palmgren (inactive)]

Checked in 2005-01-03 11:37 PDT.

-> FIXED

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using the testcase
https://bugzilla.mozilla.org/attachment.cgi?id=142904 on Windows XP, with
Seamonkey build 2005-01-17-07.