236551 - Day view improvements ( patch coming)

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Jussi Kukkonen]

First, sorry for the size of the patch that's coming, there were just a lot of
things depending on other things depending on other things... 

I tried to document a little, see below. Let me know if you don't like some of
the design decisions, or if you want more info.
 
 -Jussi

*** These were my goals (I sent this to the news group earlier):
Allday events:
--------------
- do not crop titles: use multiple lines
- try to fit allday events to as few lines as possible
- show location on allday eventbox
- allday events have borders
- allday events starting before today do not have left border, and are
  always the leftmost event on the line.
- similarly, allday events ending after today do not have right border,
  and are always the rightmost event on the line.

Normal events:
--------------
- better horizontal event placing. Events no longer overlap each other
  visually.
- location text is visible on event 
- description text is visible on event. Description may not fit 
  entirely, scrolling is not enabled.

***  This is what I changed:

- DayView.refreshEvents() is pretty much rewritten to make it more readable and
  to take advantage of the new functions. The eventboxes are still added to DOM
  in this function, but the eventbox place calculations and the actual creation
  of boxes is done in own functions, see below.
- CalendarView.setDrawProperties() is a new function that calculates eventbox
  horizontal placing attributes. Can be used from weekview too.
- DayView.setAllDayDrawProperties() is anew functionthat calculate some
  parameters aiding allday-eventbox placing and drawing
- DayView.createAllDayEventBox() is brand new. This was done in 
  refreshEvents before.
- DayView.createEventBox() is changed somewhat.

- Slight change in dayview.xul to enable the new all-day event stuff

- Some changes in calendar.css (same in both skins)

*** Known issues:

- modern skin not tested
- reeeally long all day event titles break things (happened before too)
- all-day event placing is based on a trial and error method - this might 
  mean slower screen update
- description text formatting is not respected (minor)
- sometimes there are variations in event width (really minor)

Comment 1

[Jussi Kukkonen]

Attachment: patch described in comment 0

Comment 2

[Mostafa Hosseini]

Comment on attachment 142999 [details] [diff] [review]
patch described in comment 0 

Looks good.
One issue though:
A piece of code was removed that took care of highlighting events when they
were selected in the upper list. Any reason why?
Also I beg, I dearly beg for improvements to be submitted in seperate stages.
The time to review patches grows exponentially with the size of the patch and
needs a larger chunk of time which is hard to find. I understand there are a
lot of dependencies but it is not totally impossible to categorize the change.

Comment 3

[Jussi Kukkonen]

Attachment: patch with fixes re comment2( checked in )

Looking at the patch now I must say I'm ashamed about it, you're absolutely
right about the size. I'm not going to take offence if you tell me to submit
this in phases, but I am going to leave that as your call (I'm not sure if you
did that already in comment 2 or if it was general advice for future).

About event highlighting:
Good catch. I took it off to put it into create*EventBox-functions, but clearly
my mind wandered somewhere in the middle... fixed that.

I meant what I said first - so let me know if I should redo this in smaller
parts.

Comment 4

[Mostafa Hosseini]

Comment on attachment 144567 [details] [diff] [review]
patch with fixes re comment2( checked in )

No that's fine. Thanks for understanding.
The patch looks complete now. I'll check it in when the tree opens for 1.8
since this is a big change.

Comment 5

[Mostafa Hosseini]

Comment on attachment 144567 [details] [diff] [review]
patch with fixes re comment2( checked in )

Patch checked in.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Looks like this should have been resolved fixed.

Comment 7

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!