236600 - "Open in tabs" in bm manager doesn't switch to browser view.

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Jasper]

When openening a folder in tabs in the bookmark manager Camino should swicth to
the bookmarks view. At the moment Camino stays in the bookmark manager.

We should do this because we do so whne opening single bookmarks.

Comment 1

[Jasper]

When opening a folder in tabs (using the context menu) in the bookmark manager
Camino should switch to the browser view when the tabs are loading. At the
moment Camino stays in the bookmark manager which seems akward.

If the user wants to load bookmarks in tabs I think they also wanto actually see
them being loaded.

Comment 2

[Josh Aas]

Attachment: simple fix v1

Seems important. Here is a 1-line fix.

Comment 3

[Mike Pinkerton (not reading bugmail)]

why is this needed only for the tab case? Why doesn't this get handled elsewhere
by the same code that switches views for a normal load?

Comment 4

[Mike Pinkerton (not reading bugmail)]

you know, i swear that if i apply 223701 this works

Comment 5

[Mike Pinkerton (not reading bugmail)]

nope, i was mistaken. how odd.

Comment 6

[Mike Pinkerton (not reading bugmail)]

Attachment: updated patch

i think this is a better patch. let the bwc handle ensuring visibility, in
theory the bookmark manager could be in a window by itself and shouldn't know
about bwc's.

Comment 7

[Mike Pinkerton (not reading bugmail)]

landed on trunk and branch

Comment 8

[Stuart Morgan]

Comment on attachment 148181 [details] [diff] [review]
simple fix v1

Removing review requests